fix: Windows testing broken#422
Merged
maxandersen merged 1 commit intojbangdev:masterfrom Oct 11, 2020
Merged
Conversation
The jbang.cmd script wasn't handling the creation of temp files correctly. Also the *nix verion of the script wasn't properly detecting runing on Cygwin anymore either. And finally the `build` command was returning the wrong exit code. Fixes: jbangdev#421
stalep
added a commit
to stalep/jbang
that referenced
this pull request
Apr 29, 2026
Migrate jbang's CLI framework from picocli to aesh, leveraging aesh's compile-time annotation processor to eliminate runtime reflection and improve startup performance. Key changes: - Replace all picocli annotations (@command, @option, @parameters) with aesh equivalents (@CommandDefinition, @GroupCommandDefinition, @option, @argument, @arguments, @OptionList, @OptionGroup, @mixin) - Convert Callable<Integer> commands to Command<CommandInvocation> with CommandResult return type - Port custom type converters, parameter consumers, and preprocessors to aesh Converter and OptionParser interfaces - Implement external plugin command discovery in help output - Add default value provider using aesh's post-parse processing - Wire mutual exclusion validation via aesh's exclusiveWith - Restore version checking, dynamic completion, option aliases, negatable options, and grouped help sections - Regenerate native-image configuration for aesh - Update tests for aesh CLI parsing Performance (vs picocli, median): - Native image: 6ms vs 33ms (5.5x faster) for single commands - JDK 25: 109ms vs 228ms (2.1x faster) - JDK 11: 149ms vs 269ms (1.8x faster) Picks up fixes for inherited option propagation (jbangdev#421) and @OptionGroup keys without values (jbangdev#422).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jbang.cmd script wasn't handling the creation
of temp files correctly. Also the *nix verion of
the script wasn't properly detecting runing on
Cygwin anymore either. Both are now fixed.
Fixes: #421