feat: allow configuring Liquid parser #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
This is great, thank you! I will review and merge ASAP |
JohnCampionJr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating FluentEmail to latest version and came a cross an issue which this PR hopefully fixes.
In Fluid.Core 1.x you could register custom tags using a static class which meant that one could easily add those e.g. in startup class. However Fluid.Core 2.x changed how tags are handled and I couldn't find any other way to configure those than to call RegisterXYZ method on FluidParser. As the parser instance used by FluentEmail is created in LiquidRenderer there is no way to configure it from app using FluentEmail. This PR adds a new option to configure the parser after it is created.