Open
Conversation
jcs98
force-pushed
the
jcs98/lighthouse-stats
branch
3 times, most recently
from
70d604a to
669cc68
Compare
jcs98
force-pushed
the
jcs98/lighthouse-stats
branch
from
669cc68 to
de3ad04
Compare
| { | ||
| "ci": { | ||
| "collect": { | ||
| "staticDistDir": "./website/build" |
There was a problem hiding this comment.
Instead of adding a staticDistDir. I believe this should be done
"startServerCommmand" : "yarn start",
"url" : [The URL being output by Webpack]
Owner
Author
There was a problem hiding this comment.
Do you know what is the "The URL being output by Webpack" ? I'm not sure about that.
Also yarn start will start the site on the dev server which I don't believe will give the same lighthouse scores as the actual build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
(Write your motivation here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)