Fix asyncio.iscoroutinefunction(f) check for decorated function#257
Closed
SlavaSkvortsov wants to merge 4 commits intojd:masterfrom
Closed
Fix asyncio.iscoroutinefunction(f) check for decorated function#257SlavaSkvortsov wants to merge 4 commits intojd:masterfrom
SlavaSkvortsov wants to merge 4 commits intojd:masterfrom
Conversation
jd
previously approved these changes
Oct 15, 2020
Owner
|
@Mergifyio update |
Contributor
|
Command
|
Owner
|
@Mergifyio update |
Contributor
|
Command
|
Owner
|
Looks like I don't have write access to this PR? Might be why CircleCI didn't run? |
Author
|
@jd rebased |
Owner
|
CircleCI is still ignoring it. No clue why. |
Author
|
You can just do a PR by yourself, I don't mind :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was fixed here, but the fix was removed here (I think accidentally)
Fixes: #224