fix: enable mypy strict mode in all test files#585
Merged
mergify[bot] merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
Remove blanket mypy disable comments from test_tenacity.py, test_asyncio.py, test_tornado.py, and test_after.py. Add type annotations to all test methods, helper functions, and inner functions so they pass mypy strict without suppressions. Targeted type: ignore comments are used only for intentional type mismatches in tests (e.g. passing None where BaseRetrying is expected) and dynamically-added attributes on decorated functions (.statistics, .retry, .retry_with). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: I872c723b28364cf30c546c767ad665336ef62df4
mergify
Bot
deleted the
devs/jd/fix/mypy-strict-tests/I872c723b28364cf30c546c767ad665336ef62df4
branch
Contributor
Merge Queue StatusRule:
This pull request spent 27 seconds in the queue, including 4 seconds running CI. Required conditions to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove blanket mypy disable comments from test_tenacity.py,
test_asyncio.py, test_tornado.py, and test_after.py. Add type
annotations to all test methods, helper functions, and inner
functions so they pass mypy strict without suppressions.
Targeted type: ignore comments are used only for intentional
type mismatches in tests (e.g. passing None where BaseRetrying
is expected) and dynamically-added attributes on decorated
functions (.statistics, .retry, .retry_with).
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com