fix: make LoggerProtocol compatible with logging.Logger#586
Merged
mergify[bot] merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
Remove the positional-only marker (/) from LoggerProtocol.log(). logging.Logger.log() defines msg as a regular parameter, so the positional-only constraint caused mypy to reject logging.Logger as incompatible with the protocol. Closes #554 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: Icc8ffaff0d828c5103c13e97dd2ca7701089713f
Contributor
Merge Queue StatusRule:
This pull request spent 29 seconds in the queue, including 5 seconds running CI. Required conditions to merge |
mergify
Bot
deleted the
devs/jd/fix/logger-protocol/Icc8ffaff0d828c5103c13e97dd2ca7701089713f
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the positional-only marker (/) from LoggerProtocol.log().
logging.Logger.log() defines msg as a regular parameter, so the
positional-only constraint caused mypy to reject logging.Logger
as incompatible with the protocol.
Closes #554
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com