refactor: remove redundant raise before reraise()#588
Merged
mergify[bot] merged 1 commit intomainfrom Feb 19, 2026
Merged
Conversation
reraise() is typed as NoReturn and always raises internally. The outer `raise` keyword was dead code that could never execute, and was misleading since it suggested reraise() returns an exception rather than raising one directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: I8ef31ce3d62db7d56adb0053855a1131b54f1fa5
Contributor
Merge Queue StatusRule:
This pull request spent 1 minute 16 seconds in the queue, including 13 seconds running CI. Required conditions to merge |
11 tasks
mergify
Bot
deleted the
devs/jd/fix/reraise-noreturn/I8ef31ce3d62db7d56adb0053855a1131b54f1fa5
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reraise() is typed as NoReturn and always raises internally.
The outer
raisekeyword was dead code that could never execute,and was misleading since it suggested reraise() returns an exception
rather than raising one directly.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com