fix: guard against None seconds_since_start in after_log#591
Merged
mergify[bot] merged 1 commit intomainfrom Feb 19, 2026
Conversation
`RetryCallState.seconds_since_start` returns None when `outcome_timestamp` is not set. The `%` format operator in `after_log` would crash with a TypeError in this case. Fall back to "?" when the value is None. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: Ib18f8aced63c084204b2d4719579fae4b8e557f5
jd
force-pushed
the
devs/jd/fix/after-log-none-guard/Ib18f8aced63c084204b2d4719579fae4b8e557f5
branch
from
9d0c526 to
2ad2ef3
Compare
11 tasks
mergify
Bot
deleted the
devs/jd/fix/after-log-none-guard/Ib18f8aced63c084204b2d4719579fae4b8e557f5
branch
Contributor
Merge Queue StatusRule:
This pull request spent 33 seconds in the queue, including 8 seconds running CI. Required conditions to merge |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RetryCallState.seconds_since_startreturns None whenoutcome_timestampis not set. The%format operator inafter_logwould crash with a TypeError in this case. Fall back to "?" when the
value is None.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com