Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"dev": "vite --open --force",
"dev:rtl": "VITE_RTL=rtl vite --open --force",
"dev:jmapp": "VITE_APP_PROJECT_ID=jmapp vite --open --force",
"dev:jrkf": "VITE_APP_PROJECT_ID=jrkf vite --open --force",
"dev:theme": "npm run generate:themes-dev && npm run checked && vite --force --config vite.config.theme.ts",
"dev:taro:weapp": "pnpm run update:taro:entry && pnpm --dir ./packages/nutui-taro-demo dev:weapp",
"dev:taro:jd": "pnpm run update:taro:entry && pnpm --dir ./packages/nutui-taro-demo dev:jd",
Expand Down
175 changes: 175 additions & 0 deletions src/styles/font-jrkf/config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,175 @@
{
"name": "nutui-icon",
"data": [
{
"name": "粗体 Icon",
"nameEn": "Bold Icon",
"icons": [
"order",
"refresh",
"add",
"JD",
"eye",
"dshop",
"my2",
"star",
"del2",
"more-x",
"comment",
"microphone",
"people",
"service",
"cart2",
"location2",
"marshalling",
"fabulous",
"s-follow",
"shop",
"jdl"
]
},
{
"name": "细体 Icon",
"nameEn": "Thin Icon",
"icons": [
"ask",
"tips",
"notice",
"lower",
"top",
"download",
"dongdong",
"JIMI40",
"location",
"scan",
"addfollow",
"search",
"share",
"follow",
"del",
"edit",
"cart",
"home",
"find",
"category",
"my",
"footprint",
"link",
"scan2",
"left",
"close",
"locationg3",
"share",
"shop3",
"message",
"ask2",
"search2",
"clock",
"setting",
"refresh2",
"horizontal",
"date",
"photograph",
"more-s",
"play-stop",
"play-start",
"play-double-back",
"play-double-forward",
"voice",
"image",
"image-error"
]
},
{
"name": "应用图标",
"nameEn": "Application Icon",
"icons": [
"arrow-up",
"arrow-down",
"arrow-up2",
"arrow-down2",
"down-arrow",
"joy-smile",
"close-little",
"horizontal-n",
"share-n",
"heart1",
"heart-fill",
"star-n",
"star-fill-n",
"triangle-down",
"triangle-up"
]
},
{
"name": "基础图标",
"nameEn": "Basic Icon",
"icons": [
"rect-up",
"rect-down",
"rect-left",
"rect-right",
"uploader",
"mask-close",
"circle-close",
"right",
"arrow-right",
"github",
"screen-little",
"plus",
"minus",
"Check",
"issue",
"failure",
"success",
"retweet",
"poweroff-circle-fill",
"play-circle-fill",
"checked",
"checklist",
"check-disabled",
"check-normal",
"check-checked",
"loading",
"loading1"
]
}
Comment on lines +4 to +136
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

图标分类中存在一些需要优化的地方

发现以下问题:

  1. 在"细体 Icon"分类中,"share"图标重复出现(第47行和第62行)
  2. 图标命名存在大小写不一致的情况,如"Check"(第121行)使用了大写,而其他图标都是小写
  3. 图标命名混合使用了中英文,如"JD"、"JIMI40"等

建议:

  • 删除重复的"share"图标
  • 统一使用小写命名
  • 建立统一的命名规范
      "icons": [
        "ask",
-       "share",
        "follow",
        "del",
        // ... other icons ...
-       "share",
        "shop3",
        // ... other icons ...
-       "Check",
+       "check",
        // ... other icons ...
      ]

Committable suggestion was skipped due to low confidence.


],
"style":[
{
"name": "通用动态样式",
"nameEn": "Universal Dynamic Style",
"icons": [{
"name":"dou-arrow-up",
"animation-name":"am-jump",
"animation-time":"am-infinite"
},{
"name":"star",
"animation-name":"am-blink",
"animation-time":"am-infinite"
},{
"name":"refresh2",
"animation-name":"am-rotate",
"animation-time":"am-infinite"
},{
"name":"heart-fill",
"animation-name":"am-breathe",
"animation-time":"am-infinite"
},{
"name":"microphone",
"animation-name":"am-flash",
"animation-time":"am-infinite"
},{
"name":"download",
"animation-name":"am-bounce",
"animation-time":"am-infinite"
},{
"name":"message",
"animation-name":"am-shake",
"animation-time":"am-infinite"
}
]
}
]
Comment on lines +139 to +174
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

建议完善动画配置的文档和验证

当前动画配置结构良好,但建议:

  1. 为每种动画效果添加说明文档,方便其他开发者使用
  2. 考虑添加动画时长的可配置性,而不是全部使用"am-infinite"
  3. 建议在代码中添加动画名称的验证机制,确保使用了预定义的动画类型

建议添加动画说明文档,例如:

{
  "animations": {
    "am-jump": "垂直弹跳动画",
    "am-blink": "闪烁动画",
    "am-rotate": "旋转动画",
    "am-breathe": "呼吸效果",
    "am-flash": "闪现效果",
    "am-bounce": "弹跳效果",
    "am-shake": "抖动效果"
  }
}

}
Loading