Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough本次变更涉及多个文件的删除和 Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## V3.0 #2780 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 220 220
Lines 17881 17881
Branches 2676 2676
=======================================
Hits 15018 15018
Misses 2858 2858
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
package.json (2)
Line range hint
156-164: 建议清理未使用的 Gulp 相关依赖由于已经移除了 harmony.css 和 gulpfile.js，以下依赖项可能不再需要：
- gulp
- gulp-insert
- gulp-postcss
- gulp-rename
- gulp-replace
- gulp-sass
建议在后续提交中移除这些未使用的依赖，以减少项目的依赖负担。
可以安全移除 Gulp 相关依赖
经过验证，项目中没有实际使用 Gulp：
- 构建脚本中没有使用 Gulp 相关的代码
- 所有构建相关的 npm 脚本都使用 node、vite 或 pnpm，没有使用 Gulp
- 没有发现 gulpfile 配置文件
可以安全移除以下依赖：
- gulp
- gulp-insert
- gulp-postcss
- gulp-rename
- gulp-replace
- gulp-sass
🔗 Analysis chain
Line range hint
1-248: 验证 Gulp 相关配置的清理情况让我们验证是否还有其他需要清理的 Gulp 相关配置。
Let me gather more information about the Gulp usage in the codebase to understand if these dependencies are actually being used.
Let me check if these Gulp dependencies are actually being used in the build process.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # 描述：检查是否还存在其他 Gulp 相关的配置和引用 # 搜索包含 gulp 的脚本配置 echo "检查 package.json 中的 Gulp 相关脚本：" rg "gulp" package.json # 搜索项目中其他可能的 Gulp 配置文件 echo "检查项目中的 Gulp 配置文件：" fd -e js -e ts "gulp\.config" # 搜索可能遗留的 .harmony.css 文件 echo "检查是否还存在 .harmony.css 文件：" fd ".harmony.css$"Length of output: 416
Script:
#!/bin/bash # Search for Gulp task definitions and usage in the codebase echo "Searching for Gulp task definitions and usage:" rg -g "!package.json" "gulp\." -A 3 # Search for build scripts that might use Gulp echo -e "\nSearching build-related scripts:" fd "build" scripts/ -t f -x cat {} # Check if there are any Gulp configuration files echo -e "\nSearching for gulpfile:" fd "gulpfile" -t fLength of output: 30843
Script:
#!/bin/bash # Search for actual Gulp usage in build scripts echo "Checking for Gulp usage in build scripts:" rg "gulp\." scripts/ # Check if any of the build commands in package.json use Gulp echo -e "\nChecking build-related npm scripts for Gulp usage:" jq '.scripts | with_entries(select(.key | contains("build"))) | to_entries[] | .value' package.jsonLength of output: 1043
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (75)
gulpfile.js(0 hunks)package.json(1 hunks)src/packages/actionsheet/actionsheet.harmony.css(0 hunks)src/packages/address/address.harmony.css(0 hunks)src/packages/animate/animate.harmony.css(0 hunks)src/packages/animatingnumbers/animatingnumbers.harmony.css(0 hunks)src/packages/audio/audio.harmony.css(0 hunks)src/packages/avatar/avatar.harmony.css(0 hunks)src/packages/avatarcropper/avatarcropper.harmony.css(0 hunks)src/packages/avatargroup/avatargroup.harmony.css(0 hunks)src/packages/backtop/backtop.harmony.css(0 hunks)src/packages/badge/badge.harmony.css(0 hunks)src/packages/barrage/barrage.harmony.css(0 hunks)src/packages/button/button.harmony.css(0 hunks)src/packages/calendar/calendar.harmony.css(0 hunks)src/packages/calendarcard/calendarcard.harmony.css(0 hunks)src/packages/card/card.harmony.css(0 hunks)src/packages/cascader/cascader.harmony.css(0 hunks)src/packages/cell/cell.harmony.css(0 hunks)src/packages/cellgroup/cellgroup.harmony.css(0 hunks)src/packages/checkbox/checkbox.harmony.css(0 hunks)src/packages/checkboxgroup/checkboxgroup.harmony.css(0 hunks)src/packages/circleprogress/circleprogress.harmony.css(0 hunks)src/packages/col/col.harmony.css(0 hunks)src/packages/collapseitem/collapseitem.harmony.css(0 hunks)src/packages/countdown/countdown.harmony.css(0 hunks)src/packages/dialog/dialog.harmony.css(0 hunks)src/packages/divider/divider.harmony.css(0 hunks)src/packages/drag/drag.harmony.css(0 hunks)src/packages/elevator/elevator.harmony.css(0 hunks)src/packages/ellipsis/ellipsis.harmony.css(0 hunks)src/packages/empty/empty.harmony.css(0 hunks)src/packages/fixednav/fixednav.harmony.css(0 hunks)src/packages/form/form.harmony.css(0 hunks)src/packages/formitem/formitem.harmony.css(0 hunks)src/packages/grid/grid.harmony.css(0 hunks)src/packages/griditem/griditem.harmony.css(0 hunks)src/packages/hoverbutton/hoverbutton.harmony.css(0 hunks)src/packages/hoverbuttonitem/hoverbuttonitem.harmony.css(0 hunks)src/packages/image/image.harmony.css(0 hunks)src/packages/imagepreview/imagepreview.harmony.css(0 hunks)src/packages/indicator/indicator.harmony.css(0 hunks)src/packages/infiniteloading/infiniteloading.harmony.css(0 hunks)src/packages/input/input.harmony.css(0 hunks)src/packages/inputnumber/inputnumber.harmony.css(0 hunks)src/packages/loading/loading.harmony.css(0 hunks)src/packages/menu/menu.harmony.css(0 hunks)src/packages/menuitem/menuitem.harmony.css(0 hunks)src/packages/navbar/navbar.harmony.css(0 hunks)src/packages/noticebar/noticebar.harmony.css(0 hunks)src/packages/notify/notify.harmony.css(0 hunks)src/packages/numberkeyboard/numberkeyboard.harmony.css(0 hunks)src/packages/overlay/overlay.harmony.css(0 hunks)src/packages/pagination/pagination.harmony.css(0 hunks)src/packages/picker/picker.harmony.css(0 hunks)src/packages/popover/popover.harmony.css(0 hunks)src/packages/popup/popup.harmony.css(0 hunks)src/packages/price/price.harmony.css(0 hunks)src/packages/progress/progress.harmony.css(0 hunks)src/packages/pulltorefresh/pulltorefresh.harmony.css(0 hunks)src/packages/radio/radio.harmony.css(0 hunks)src/packages/radiogroup/radiogroup.harmony.css(0 hunks)src/packages/range/range.harmony.css(0 hunks)src/packages/rate/rate.harmony.css(0 hunks)src/packages/resultpage/resultpage.harmony.css(0 hunks)src/packages/row/row.harmony.css(0 hunks)src/packages/safearea/safearea.harmony.css(0 hunks)src/packages/searchbar/searchbar.harmony.css(0 hunks)src/packages/shortpassword/shortpassword.harmony.css(0 hunks)src/packages/sidenavbar/sidenavbar.harmony.css(0 hunks)src/packages/sidenavbaritem/sidenavbaritem.harmony.css(0 hunks)src/packages/signature/signature.harmony.css(0 hunks)src/packages/skeleton/skeleton.harmony.css(0 hunks)src/packages/space/space.harmony.css(0 hunks)src/packages/step/step.harmony.css(0 hunks)
⛔ Files not processed due to max files limit (23)
- src/packages/steps/steps.harmony.css
- src/packages/sticky/sticky.harmony.css
- src/packages/subsidenavbar/subsidenavbar.harmony.css
- src/packages/swipe/swipe.harmony.css
- src/packages/swiper/swiper.harmony.css
- src/packages/swiperitem/swiperitem.harmony.css
- src/packages/switch/switch.harmony.css
- src/packages/tabbar/tabbar.harmony.css
- src/packages/tabbaritem/tabbaritem.harmony.css
- src/packages/table/table.harmony.css
- src/packages/tabpane/tabpane.harmony.css
- src/packages/tabs/tabs.harmony.css
- src/packages/tag/tag.harmony.css
- src/packages/textarea/textarea.harmony.css
- src/packages/timedetail/timedetail.harmony.css
- src/packages/timeselect/timeselect.harmony.css
- src/packages/toast/toast.harmony.css
- src/packages/tour/tour.harmony.css
- src/packages/trendarrow/trendarrow.harmony.css
- src/packages/uploader/uploader.harmony.css
- src/packages/video/video.harmony.css
- src/packages/virtuallist/virtuallist.harmony.css
- src/packages/watermark/watermark.harmony.css
💤 Files with no reviewable changes (74)
- gulpfile.js
- src/packages/actionsheet/actionsheet.harmony.css
- src/packages/address/address.harmony.css
- src/packages/animate/animate.harmony.css
- src/packages/animatingnumbers/animatingnumbers.harmony.css
- src/packages/audio/audio.harmony.css
- src/packages/avatar/avatar.harmony.css
- src/packages/avatarcropper/avatarcropper.harmony.css
- src/packages/avatargroup/avatargroup.harmony.css
- src/packages/backtop/backtop.harmony.css
- src/packages/badge/badge.harmony.css
- src/packages/barrage/barrage.harmony.css
- src/packages/button/button.harmony.css
- src/packages/calendar/calendar.harmony.css
- src/packages/calendarcard/calendarcard.harmony.css
- src/packages/card/card.harmony.css
- src/packages/cascader/cascader.harmony.css
- src/packages/cell/cell.harmony.css
- src/packages/cellgroup/cellgroup.harmony.css
- src/packages/checkbox/checkbox.harmony.css
- src/packages/checkboxgroup/checkboxgroup.harmony.css
- src/packages/circleprogress/circleprogress.harmony.css
- src/packages/col/col.harmony.css
- src/packages/collapseitem/collapseitem.harmony.css
- src/packages/countdown/countdown.harmony.css
- src/packages/dialog/dialog.harmony.css
- src/packages/divider/divider.harmony.css
- src/packages/drag/drag.harmony.css
- src/packages/elevator/elevator.harmony.css
- src/packages/ellipsis/ellipsis.harmony.css
- src/packages/empty/empty.harmony.css
- src/packages/fixednav/fixednav.harmony.css
- src/packages/form/form.harmony.css
- src/packages/formitem/formitem.harmony.css
- src/packages/grid/grid.harmony.css
- src/packages/griditem/griditem.harmony.css
- src/packages/hoverbutton/hoverbutton.harmony.css
- src/packages/hoverbuttonitem/hoverbuttonitem.harmony.css
- src/packages/image/image.harmony.css
- src/packages/imagepreview/imagepreview.harmony.css
- src/packages/indicator/indicator.harmony.css
- src/packages/infiniteloading/infiniteloading.harmony.css
- src/packages/input/input.harmony.css
- src/packages/inputnumber/inputnumber.harmony.css
- src/packages/loading/loading.harmony.css
- src/packages/menu/menu.harmony.css
- src/packages/menuitem/menuitem.harmony.css
- src/packages/navbar/navbar.harmony.css
- src/packages/noticebar/noticebar.harmony.css
- src/packages/notify/notify.harmony.css
- src/packages/numberkeyboard/numberkeyboard.harmony.css
- src/packages/overlay/overlay.harmony.css
- src/packages/pagination/pagination.harmony.css
- src/packages/picker/picker.harmony.css
- src/packages/popover/popover.harmony.css
- src/packages/popup/popup.harmony.css
- src/packages/price/price.harmony.css
- src/packages/progress/progress.harmony.css
- src/packages/pulltorefresh/pulltorefresh.harmony.css
- src/packages/radio/radio.harmony.css
- src/packages/radiogroup/radiogroup.harmony.css
- src/packages/range/range.harmony.css
- src/packages/rate/rate.harmony.css
- src/packages/resultpage/resultpage.harmony.css
- src/packages/row/row.harmony.css
- src/packages/safearea/safearea.harmony.css
- src/packages/searchbar/searchbar.harmony.css
- src/packages/shortpassword/shortpassword.harmony.css
- src/packages/sidenavbar/sidenavbar.harmony.css
- src/packages/sidenavbaritem/sidenavbaritem.harmony.css
- src/packages/signature/signature.harmony.css
- src/packages/skeleton/skeleton.harmony.css
- src/packages/space/space.harmony.css
- src/packages/step/step.harmony.css
🔇 Additional comments (1)
package.json (1)
69-69: 脚本简化符合预期
删除 gulp:watch 命令的修改与移除 harmony.css 的目标一致，因为现在不再需要监视 CSS 文件的变化。
xiaoyatong
reviewed
Nov 21, 2024
| @@ -1,130 +0,0 @@ | |||
| const gulp = require('gulp') | |||
scripts/build-taro.mjs
Outdated
Comment on lines
294
to
297
| // if (file.indexOf('countup') === -1) { | ||
| // await copy(join(__dirname, '../', file.replace('scss', 'harmony.css')), join('dist/cjs', cssPath, 'style/style.harmony.css')) | ||
| // await copy(join(__dirname, '../', file.replace('scss', 'harmony.css')), join('dist/es', cssPath, 'style/style.harmony.css')) | ||
| // } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
建议完全删除不再需要的代码
由于 Harmony 现在支持 CSS 变量，.harmony.css 文件已不再需要。与其注释掉这段代码，建议直接删除这些行，以保持代码库的整洁性。
应用以下更改：
- // if (file.indexOf('countup') === -1) {
- // await copy(join(__dirname, '../', file.replace('scss', 'harmony.css')), join('dist/cjs', cssPath, 'style/style.harmony.css'))
- // await copy(join(__dirname, '../', file.replace('scss', 'harmony.css')), join('dist/es', cssPath, 'style/style.harmony.css'))
- // }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // if (file.indexOf('countup') === -1) { | |
| // await copy(join(__dirname, '../', file.replace('scss', 'harmony.css')), join('dist/cjs', cssPath, 'style/style.harmony.css')) | |
| // await copy(join(__dirname, '../', file.replace('scss', 'harmony.css')), join('dist/es', cssPath, 'style/style.harmony.css')) | |
| // } |
💡 Codebase verification
harmony CSS 文件清理情况需要进一步处理
代码检查发现以下问题：
- 多个组件的 SCSS 文件中仍然保留着 harmony 相关的条件编译代码
- 构建脚本中还存在 harmony CSS 相关的注释代码
- package.json 中仍保留着 harmony 相关的构建命令
需要处理的文件：
- src/packages/badge/badge.scss
- src/packages/button/button.scss
- src/packages/inputnumber/inputnumber.scss
- src/packages/navbar/navbar.scss
- src/packages/toast/toast.scss
- src/packages/hoverbuttonitem/hoverbuttonitem.scss
- scripts/build-taro.mjs
- package.json
建议：
- 清理所有组件 SCSS 文件中的 harmony 条件编译代码
- 完全移除构建脚本中的 harmony CSS 相关注释
- 评估是否需要保留 package.json 中的 harmony 相关命令
🔗 Analysis chain
验证 harmony CSS 文件的清理情况
为确保 harmony CSS 相关文件的完全移除，需要验证以下几点：
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# 检查是否还存在 .harmony.css 文件
echo "检查剩余的 .harmony.css 文件..."
fd -e harmony.css
# 检查代码中是否还有对 harmony.css 的引用
echo "检查代码中对 harmony.css 的引用..."
rg "\.harmony\.css" -t js -t ts -t tsx
Length of output: 208
Script:
#!/bin/bash
# 检查是否还存在 .harmony.css 文件
echo "检查剩余的 .harmony.css 文件..."
find . -name "*.harmony.css"
# 检查代码中对 harmony.css 的引用（修正文件类型）
echo "检查代码中对 harmony.css 的引用..."
rg "harmony\.css" -t js -t jsx -t ts
# 检查构建脚本中的相关引用
echo "检查构建脚本中的相关引用..."
rg "harmony" scripts/
# 检查样式相关文件
echo "检查样式文件中的相关引用..."
find . -type f -name "*.scss" -o -name "*.css" | xargs grep -l "harmony"
Length of output: 2084
Script:
#!/bin/bash
# 检查 SCSS 文件中的 harmony 相关代码
echo "检查 SCSS 文件中的 harmony 相关内容..."
for file in src/packages/badge/badge.scss src/packages/button/button.scss src/packages/inputnumber/inputnumber.scss src/packages/navbar/navbar.scss src/packages/toast/toast.scss src/packages/hoverbuttonitem/hoverbuttonitem.scss; do
echo "=== $file ==="
grep -A 2 -B 2 "harmony" "$file"
done
# 检查是否有遗留的 harmony.css 构建产物
echo "检查构建目录中的 harmony.css 文件..."
find dist/ -name "*harmony.css" 2>/dev/null || true
# 检查 package.json 中的相关配置
echo "检查 package.json 中的 harmony 相关配置..."
grep -i "harmony" package.json || true
Length of output: 4347
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
现在鸿蒙已经支持 css 变量，所以删除 harmony.css 文件
Summary by CodeRabbit
Bug 修复
功能更新
@nutui/nutui-react-taro包的版本至3.0.0-beta.3。dev:taro:jdrn脚本的执行流程，移除了不必要的命令。文档