Skip to content

Comments

fix(ci): corepack manager use pnpm failed#2970

Merged
xiaoyatong merged 1 commit intojdf2e:nextfrom
Miles-hxy:fix_next_ci
Feb 7, 2025
Merged

fix(ci): corepack manager use pnpm failed#2970
xiaoyatong merged 1 commit intojdf2e:nextfrom
Miles-hxy:fix_next_ci

Conversation

@Miles-hxy
Copy link
Collaborator

@Miles-hxy Miles-hxy commented Feb 7, 2025

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • Chores
    • 更新了 CI/CD 工作流配置,改进了依赖安装流程以提升构建和测试的稳定性。
  • Style
    • 调整了部分工作流配置文件的格式,提高了可读性和维护性。

@coderabbitai
Copy link

coderabbitai bot commented Feb 7, 2025

Walkthrough

此次 PR 修改了多个 GitHub Actions 工作流文件中的 pnpm 安装命令。原先使用 “corepack enable pnpm” 启用 pnpm,如今全部替换为 “npm i -g pnpm” 以全局安装。受影响的文件包括 ci.yml、realease-tag.yml、sync-h5.yml、sync-migrate.yml 和 sync-taro.yml。除安装命令外,工作流的其他步骤、触发条件及导出的公共实体均保持不变。

Changes

文件路径 更改说明
.github/workflows/ci.yml, .github/workflows/re…tag.yml, .github/workflows/sync-h5.yml, .github/workflows/sync-migrate.yml, .github/workflows/sync-taro.yml 将 “corepack enable pnpm” 替换为 “npm i -g pnpm”;sync-h5.yml 还做了少量格式调整

Possibly related PRs

Suggested reviewers

  • oasis-cloud

Poem

我是跳跃的小兔,穿梭在代码丛林中,
pnpm 的新方式,让流程变得更通畅。
告别旧命令的影子,迎来全局安装的曙光,
每一步都轻快如舞,代码也欢笑着闪亮,
让我们伴着这变化,共赴未来的美好时光! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 2.x Target branch 2.x label Feb 7, 2025
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.19%. Comparing base (0cbcfdd) to head (6e6757c).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2970   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files         267      267           
  Lines       18099    18099           
  Branches     2665     2665           
=======================================
  Hits        15238    15238           
  Misses       2856     2856           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
.github/workflows/realease-tag.yml (1)

17-17: 确认pnpm安装命令的修改
此处将原来的 “corepack enable pnpm” 替换为 “npm i -g pnpm”,采用全局安装方式来确保 pnpm 可用,能够解决 Corepack 相关的问题。建议后续如有版本稳定性需求,可考虑指定安装版本。

.github/workflows/sync-h5.yml (1)

20-20: 全局安装pnpm命令确认
将 “corepack enable pnpm” 修改为 “npm i -g pnpm” 能够确保在 CI 环境中正确安装 pnpm,支持后续依赖安装和构建任务。建议后续关注 pnpm 版本问题以避免潜在不一致性。

.github/workflows/sync-taro.yml (1)

20-20: 确认pnpm安装命令更新
此处采用 "npm i -g pnpm" 替换旧的 Corepack 命令,保证环境中 pnpm 的全局安装,从而确保后续文档同步和依赖安装流程正常运行。

.github/workflows/sync-migrate.yml (1)

21-21: 更新全局安装pnpm命令
使用 "npm i -g pnpm" 替换原有的 Corepack 命令,确保在迁移同步任务中全局安装 pnpm,有助于提升 CI 流程的稳定性。建议后续检查是否需要对 pnpm 版本进行锁定。

.github/workflows/ci.yml (1)

64-66: 在 Build 任务中确认pnpm安装命令
在构建流程中采用 “npm i -g pnpm” 命令,确保 pnpm 全局安装,从而维持依赖安装和构建步骤的稳定性。建议注意与缓存及版本管理相关的潜在问题。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0cbcfdd and 6e6757c.

📒 Files selected for processing (5)
  • .github/workflows/ci.yml (3 hunks)
  • .github/workflows/realease-tag.yml (1 hunks)
  • .github/workflows/sync-h5.yml (1 hunks)
  • .github/workflows/sync-migrate.yml (1 hunks)
  • .github/workflows/sync-taro.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (2)
.github/workflows/ci.yml (2)

20-21: 在 Lint 任务中确认pnpm安装命令
将 “corepack enable pnpm” 修改为 “npm i -g pnpm”,确保在 Lint 流程中全局安装 pnpm,从而避免因 Corepack 导致的安装失败问题。


39-41: 在 Test 任务中确认pnpm安装命令
此修改确保在测试流程中 pnpm 能够全局安装并正常使用,保障后续依赖安装和测试执行的一致性。

@Miles-hxy Miles-hxy changed the title fix: corepack manager use pnpm failed fix(ci): corepack manager use pnpm failed Feb 7, 2025
@xiaoyatong xiaoyatong merged commit 343116f into jdf2e:next Feb 7, 2025
6 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 13, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.x Target branch 2.x size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants