Skip to content

Comments

chore: remove rn#3000

Merged
oasis-cloud merged 2 commits intojdf2e:feat_v3.xfrom
xiaoyatong:remove-rn
Feb 20, 2025
Merged

chore: remove rn#3000
oasis-cloud merged 2 commits intojdf2e:feat_v3.xfrom
xiaoyatong:remove-rn

Conversation

@xiaoyatong
Copy link
Collaborator

@xiaoyatong xiaoyatong commented Feb 19, 2025

🤔 这个变动的性质是?

删除rn相关遗留文件。

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 文档

    • 更新了依赖安装命令,简化了安装流程描述。
  • 杂项

    • 调整了依赖解析机制,确保关键依赖得到保留。
    • 移除了部分不再使用的示例模块、插件引用、版本记录和旧构建配置。
    • 清理了冗余注释,优化了代码结构。

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

此次变更涉及多个文件调整,主要对依赖处理、安装命令以及导入配置进行了修改。.pnpmfile.cjs 中修改了 readPackage 函数的依赖移除逻辑,保留了特殊包的依赖;README.md 中更新了安装命令;在 packages/nutui-taro-demo 目录下,删除了部分文件和导入语句,调整了 metro 配置;另外,部分文件中的注释被移除,而接口声明保持不变。

Changes

文件路径 变更摘要
.pnpmfile.cjs 修改 readPackage 函数:不再删除 @jdreact/jdreact-jsbundle-commonpack ,对其他依赖仍保持删除逻辑。
README.md 更新安装命令:由 pnpm install 改为 pnpm install --ignore-pnpmfile
packages/nutui-taro-demo/index.js 删除了对 @jdtaro/plugin-platform-jdrn/entry-file.js 的导入。
packages/nutui-taro-demo/jsbundles/JDReactAPIDemos.* 删除 JDReactAPIDemos.jsJDReactAPIDemos.version 文件。
packages/nutui-taro-demo/metro.config.js 删除 Metro bundler 配置文件。
src/packages/backtop/demos/taro/demo5.tsx 移除了文件开始处的注释块,代码功能无变化。

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

  • oasis-cloud

Poem

小兔跳跃在代码林,
更新改动留踪迹。
删除旧导入新命令,
依赖逻辑巧调试。
代码如诗舞春风,
愿改动带来新生机!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) labels Feb 19, 2025
@xiaoyatong xiaoyatong requested a review from irisSong February 19, 2025 02:52
@irisSong irisSong self-requested a review February 19, 2025 04:04
Copy link
Collaborator

@irisSong irisSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci没过

@irisSong irisSong self-requested a review February 19, 2025 04:05
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (a5014bf) to head (94f5c76).
Report is 3 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #3000   +/-   ##
==========================================
  Coverage      85.79%   85.79%           
==========================================
  Files            281      281           
  Lines          18527    18527           
  Branches        2810     2810           
==========================================
  Hits           15896    15896           
  Misses          2626     2626           
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oasis-cloud oasis-cloud merged commit e7eb6f1 into jdf2e:feat_v3.x Feb 20, 2025
8 checks passed
oasis-cloud added a commit to oasis-cloud/nutui-react that referenced this pull request Feb 20, 2025
* chore: remove rn

* fix: ci error

---------

Co-authored-by: oasis <suanbanren@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants