Skip to content

Comments

fix(uploader): 多端上传媒体文件逻辑与2x保持一致#3223

Merged
xiaoyatong merged 1 commit intojdf2e:feat_v3.xfrom
Miles-hxy:fix_uploader_video
May 15, 2025
Merged

fix(uploader): 多端上传媒体文件逻辑与2x保持一致#3223
xiaoyatong merged 1 commit intojdf2e:feat_v3.xfrom
Miles-hxy:fix_uploader_video

Conversation

@Miles-hxy
Copy link
Collaborator

@Miles-hxy Miles-hxy commented May 15, 2025

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 优化
    • 扩展了图片选择功能,现在在 Web 环境下也支持使用 chooseMedia 进行图片选择。

@coderabbitai
Copy link

coderabbitai bot commented May 15, 2025

Walkthrough

本次更改对 src/packages/uploader/uploader.taro.tsx 文件中的 _chooseImage 函数进行了环境检测逻辑的重构。将多次调用的 getEnv() 结果存储在本地变量 env,并扩展了 chooseMedia API 的适用环境,将 'WEB' 也纳入判断范围。

Changes

文件/文件组 变更摘要
src/packages/uploader/uploader.taro.tsx 重构 _chooseImage 环境检测逻辑,减少 getEnv() 调用次数,并将 'WEB' 环境纳入 chooseMedia 的适用范围。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Uploader
    participant Taro

    User->>Uploader: 触发 _chooseImage
    Uploader->>Taro: 获取环境 (getEnv)
    Uploader->>Uploader: 判断 env
    alt env 为 WEAPP/JD/WEB 且 chooseMedia 可用
        Uploader->>Taro: 调用 chooseMedia
    else env 为 WEB
        Uploader->>Taro: 调用 chooseImage
    end
Loading

Possibly related PRs

Suggested reviewers

  • oasis-cloud

Poem

小兔敲键盘,环境巧判断,
一次取结果,效率翻新篇。
WEB 也能选,媒体齐上阵,
上传更便捷,代码更轻盈。
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9499ec7 and 155d829.

📒 Files selected for processing (1)
  • src/packages/uploader/uploader.taro.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: test
🔇 Additional comments (2)
src/packages/uploader/uploader.taro.tsx (2)

139-140: 优化:将 getEnv() 的结果存储在本地变量中

通过将环境值存储在局部变量 env 中,避免了多次调用 getEnv() 函数,提高了代码的效率和可读性。


156-156: 扩展 chooseMedia API 的适用环境

'WEB' 环境添加到 chooseMedia API 的适用范围中,使其与 2.x 版本保持一致。确保 chooseMedia API 在 Web 环境中能正常工作。

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the action:review This PR needs more reviews (less than 2 approvals) label May 15, 2025
@Miles-hxy Miles-hxy requested a review from xiaoyatong May 15, 2025 02:13
@github-actions github-actions bot added the 3.x Target branch 3.x label May 15, 2025
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (9499ec7) to head (155d829).
Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           feat_v3.x    #3223   +/-   ##
==========================================
  Coverage      86.70%   86.70%           
==========================================
  Files            291      291           
  Lines          19062    19062           
  Branches        2891     2892    +1     
==========================================
  Hits           16528    16528           
  Misses          2529     2529           
  Partials           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiaoyatong xiaoyatong merged commit ece37a2 into jdf2e:feat_v3.x May 15, 2025
8 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 8, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x Target branch 3.x action:review This PR needs more reviews (less than 2 approvals) size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants