fix: fix showCount props is invalid in alipay#3366
Merged
xiaoyatong merged 1 commit intojdf2e:feat_v3.xfrom Oct 16, 2025
Merged
fix: fix showCount props is invalid in alipay#3366xiaoyatong merged 1 commit intojdf2e:feat_v3.xfrom
xiaoyatong merged 1 commit intojdf2e:feat_v3.xfrom
Conversation
Walkthrough在 Taro 版 Textarea 调用处新增 showCount 属性透传至底层 Taro Textarea。现有字符计数的条件渲染保持不变,无控制流调整;对外导出或公共声明未变更。 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
xiaoyatong
approved these changes
Oct 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3366 +/- ##
==========================================
Coverage 88.15% 88.15%
==========================================
Files 291 291
Lines 19212 19212
Branches 2988 2988
==========================================
Hits 16937 16937
Misses 2269 2269
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiaoyatong
approved these changes
Oct 16, 2025
xiaoyatong
pushed a commit
that referenced
this pull request
Nov 14, 2025
* fix: fix showCount props is invalid in alipay (#3366) * feat: 添加部分组件无障碍功能支持 - button - Checkbox - Countdown - Empty - Image - InputNumber - Price - Progress - NavBar - NoticeBar - Radio - Switch - Tabbar - Tabs - Toast * Revert "feat: 添加部分组件无障碍功能支持" This reverts commit 2e7cbd2. * feat: 添加组件无障碍功能支持 - button - Checkbox - Popup - Dialog - Overlay - Radio - Switch - Toast * fix: update * fix: update * fix: update * fix: update Overlay --------- Co-authored-by: ryanwang <email@binlin.wang>
xiaoyatong
pushed a commit
that referenced
this pull request
Dec 18, 2025
* fix(badge): 解决中文偏上问题 * fix: css 变量更新 * fix: 更正正黑字体 * fix: 更正正黑字体 * feat: 更新字体版本 * fix: fix showCount props is invalid in alipay (#3366) * feat(price): dynamic和harmony结构保持一致 * feat(ascf): 支持ASCF鸿蒙元服务 (#3402) Co-authored-by: ext.liuweijian3 <1187831341@qq.com> * fix(steps): taro版本div标签替换成view标签 --------- Co-authored-by: ryanwang <email@binlin.wang> Co-authored-by: 2extliuweijian32 <ext.liuweijian3@jd.com> Co-authored-by: ext.liuweijian3 <1187831341@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
Relation Taro TextArea Issue
☑️ 请求合并前的自查清单
Summary by CodeRabbit