do not show diff for credentials file#62
Merged
jdowning merged 1 commit intojdowning:masterfrom Aug 24, 2019
Merged
Conversation
Contributor
|
Funny, just ran into this and noticed I was too late for a PR :-) @jdowning Would you mind tagging a bugfix release for this? 🍻 |
Owner
|
@mpdude 😬 Better late than never? 😎 https://forge.puppet.com/jdowning/awscli/2.2.0/readme |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently credentials are being written in plaintext to syslog any time the credentials file changes, which is not ideal. This PR suppresses output when modifying credential files so that this will no longer happen.
I have a temporary solution in place using a resource collector to disable show_diff, but this seems like it should probably be the default behavior NOT to display the password in the log.