Use published clap-sort crate instead of inlined module

[jdx]

Summary

`src/clap_sort.rs` has been duplicating the logic of the published `clap-sort` crate since the crate was released. This PR deletes the 461-line inlined copy and depends on `clap-sort = "1"` as a dev-dependency instead.

The two implementations are functionally equivalent for fnox's current CLI (the test passes both before and after), but the published crate has one improvement the inlined version didn't:

• Positional args keep source order. The inlined version asserts positional args be alphabetical by id, which conflicts with clap's positional-parsing semantics (e.g. a `trailing_var_arg` must come last). The published crate documents this explicitly at `src/lib.rs:152`:

  ```
  // Note: We don't check if positional args are sorted - their order matters for parsing
  ```

  fnox's CLI happens not to have multi-positional commands today, so the inlined rule never fires, but it would break if one were added.

Changes

• Delete `src/clap_sort.rs` (461 lines)
• Drop `mod clap_sort;` from `src/lib.rs` and `src/main.rs`
• `src/commands/mod.rs`: `test_cli_ordering` now calls `clap_sort::assert_sorted(&Cli::command())`
• Add `clap-sort = "1"` to `[dev-dependencies]`

Test plan

• `cargo test test_cli_ordering` — passes on both `lib` and `bin` targets
• `cargo clippy --all-targets` — no new warnings (3 pre-existing `assert_eq!` warnings are unrelated)
• `cargo fmt --check` — clean

🤖 Generated with Claude Code

---

Note

Low Risk
Low risk: replaces an internal test-only CLI ordering validator with the published clap-sort dev-dependency; runtime code paths are unchanged aside from test behavior.

Overview
Switches CLI ordering validation tests from an in-repo src/clap_sort.rs implementation to the published clap-sort crate (clap_sort::assert_sorted).

Removes the inlined 461-line module and its references from lib.rs/main.rs, and adds clap-sort = "1" as a dev-dependency (updating Cargo.lock accordingly).

^{Reviewed by Cursor Bugbot for commit 17f2491. Bugbot is set up for automated code reviews on this repo. Configure here.}

[greptile-apps]

Greptile Summary

Replaces the 461-line inlined src/clap_sort.rs module with the published clap-sort = "1" dev-dependency, updating the test_cli_ordering test to call clap_sort::assert_sorted. The core migration is clean and correct; all runtime code paths are unchanged.

The PR also includes changes to docs/public/schema.json that reorder ProviderConfig.oneOf entries but are not described in the PR description — worth confirming these are intentional.

Confidence Score: 5/5

Safe to merge — runtime code paths are entirely unchanged; only the test-only CLI-ordering validator is swapped for its published equivalent.

All remaining findings are P2. The schema.json reordering is functionally equivalent (JSON Schema oneOf is order-agnostic for validation), and the core clap-sort migration is correct, clean, and well-scoped.

docs/public/schema.json — worth confirming the provider ordering change is intentional and not incidental noise from another branch.

Important Files Changed

Filename	Overview
src/clap_sort.rs	461-line inlined module deleted entirely; replaced by the published crate.
src/commands/mod.rs	Test updated to call clap_sort::assert_sorted(&Cli::command()) — correct use of the published crate's API.
Cargo.toml	Adds clap-sort = "1" under [dev-dependencies] as intended.
docs/public/schema.json	ProviderConfig.oneOf entries reordered (pure positional shuffle, no content changes per provider) — not mentioned in the PR description.
src/lib.rs	Removes mod clap_sort; declaration cleanly.
src/main.rs	Removes mod clap_sort; declaration cleanly.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[test_cli_ordering] -->|before| B[src/clap_sort.rs
assert_command_order]
    A -->|after| C[clap-sort v1.0.3
clap_sort::assert_sorted]
    B --> D[461 lines removed]
    C --> E[Cargo.toml dev-dep]
    E --> F[Cargo.lock locked to 1.0.3]

Loading

_{Reviews (2): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	cargo/​clap-sort@​1.0.3

View full report

[gemini-code-assist]

Code Review

This pull request replaces the internal clap_sort module with the external clap-sort crate. The changes include adding the dependency to Cargo.toml and Cargo.lock, deleting the local implementation, and updating the CLI ordering test to use the external crate. A review comment suggests removing a redundant code comment in the test file.

[gemini-code-assist]

The comment 'using the published clap-sort crate.' is redundant as the code change itself makes this clear. Please remove this comment to keep the code clean.