Skip to content

Fix performance test in CI#205

Merged
6cdh merged 2 commits intojeapostrophe:masterfrom
6cdh:fix-test
Mar 27, 2026
Merged

Fix performance test in CI#205
6cdh merged 2 commits intojeapostrophe:masterfrom
6cdh:fix-test

Conversation

@6cdh
Copy link
Copy Markdown
Collaborator

@6cdh 6cdh commented Mar 26, 2026

  • Increase time budget in tests
  • Use CPU count instead of hardcoded 16 in raco test

- Increase time budget in tests
- Use CPU count instead of hardcoded 16 in `raco test`
@6cdh 6cdh requested a review from dannypsnl March 26, 2026 14:57
Comment thread .github/workflows/ci.yml
@dannypsnl
Copy link
Copy Markdown
Collaborator

Can we also update info.rkt here? --check-pkg-deps should help us to find dependency that no declarations.

@6cdh
Copy link
Copy Markdown
Collaborator Author

6cdh commented Mar 27, 2026

I removed the legacy text buffer, because raco setup compiles all Racket files in the project. It makes GUI library used when compiling legacy text buffer. I also removed the benchmark script because there is no comparison target now.

Comment thread tests/lib/editor-test.rkt
@6cdh 6cdh merged commit bafff8b into jeapostrophe:master Mar 27, 2026
10 checks passed
@6cdh 6cdh deleted the fix-test branch March 27, 2026 03:39
@shhyou
Copy link
Copy Markdown
Contributor

shhyou commented Apr 8, 2026

What's the rationale to remove racket-doc from the dependency? It's causing raco setup problems because building the documentation depends on it.

@shhyou
Copy link
Copy Markdown
Contributor

shhyou commented Apr 8, 2026

#189 I think. Running raco setup --check-pkg-deps --pkgs racket-langserver reports the missing dependency.

@shhyou
Copy link
Copy Markdown
Contributor

shhyou commented Apr 8, 2026

The CI script intentionally skips building the documentation via --no-docs so it won't report this dependency.

- name: Checking the package dependency of racket-langserver
run: raco setup -j "$(getconf _NPROCESSORS_ONLN)" --no-docs --check-pkg-deps --unused-pkg-deps --pkgs racket-langserver

@dannypsnl
Copy link
Copy Markdown
Collaborator

We can create an independent yaml to check dependencies.

@6cdh
Copy link
Copy Markdown
Collaborator Author

6cdh commented Apr 8, 2026

I forgot that PR totally, and didn't notice what --no-docs do. It was my mistake, and should be fixed quickly.

@shhyou
Copy link
Copy Markdown
Contributor

shhyou commented Apr 8, 2026

Ah, thanks for the immediate fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants