Allow developers to use retry-logic for mutations when they know it's safe#15
Merged
Allow developers to use retry-logic for mutations when they know it's safe#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Our client library has a simple retry implementation, intended to catch one-off transient errors that might happen in production. This is useful, for example, in cron jobs that loop over a large number of requests -- if a single transient error does occur, the client can issue a retry to avoid the developer using the library from having to handle those exceptions.
Previously, we removed that retry logic for mutation-based queries, as it's possible the transient error occurred after the mutation successfully executed, and double-running a mutation could put the data into an inconsistent state. However, sometimes a developer knows that the mutation is safe to replay.
Solution
Very simply: allow the developer to say, "it's okay to replay mutation" via a boolean flag.