docs: slsa editorial fixes#3
Merged
jedevc merged 3 commits intojedevc:attestations-provenance-docsfrom Jan 4, 2023
Merged
Conversation
Signed-off-by: David Karlsson <david.karlsson@docker.com>
Signed-off-by: David Karlsson <david.karlsson@docker.com>
dvdksn
force-pushed
the
docs/slsa-editorial
branch
from
1a2277a to
c1d5282
Compare
jedevc
reviewed
Jan 3, 2023
Owner
jedevc
left a comment
jedevc
left a comment
There was a problem hiding this comment.
Couple minor nits, the editorial fixes look good to me.
I think splitting up into multiple files should be good, PTAL @tonistiigi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates moby#3375
Signed-off-by: David Karlsson david.karlsson@docker.com
modethe attestation fields are included inAlso forked the field definitions into a separate page. My intention here was to
make this content reusable by the Docker docs repository downstream. In addition
to moving the text to a separate file, I had to remove a couple of references to
buildctl, to make this page client-agnostic.