Open
Conversation
…resence of a left child.
… only has a right child.
There was a problem hiding this comment.
I see three conditions here:
- the node has no children
- the node has at least a left child
- any other situation
I don't think this is an exhaustive set of the possibilities for deletion. Make sure you have tests that cover having a child to the left, a child to the right and children on both sides. Make sure you test having extra nodes below the children of the node to be deleted. With exhaustive tests you can be sure everything is working, but your tests do not appear exhaustive to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.