Require Jenkins 2.479.3 or newer and Jakarta EE 9 #516

strangelookingnerd · 2025-04-24T10:20:33Z

Require Jenkins 2.479.3 or newer and Jakarta EE 9

Jenkins 2.479.3 provides Jakarta EE 9, Eclipse Jetty 12, Spring Security 6, and Java 17.

Update plugin pom and baseline
Remove deprecations
Use Java 17 language features
Minor cleanup

Testing done

mvn clean verify

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue

src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement.java


    @Override
-    public ContextMenu doContextMenu(StaplerRequest request, StaplerResponse response) throws Exception {
+    public ContextMenu doContextMenu(StaplerRequest2 request, StaplerResponse2 response) throws Exception {


src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/Diagnostics.java


    @Override
-    public ContextMenu doChildrenContextMenu(StaplerRequest request, StaplerResponse response) throws Exception {
+    public ContextMenu doChildrenContextMenu(StaplerRequest2 request, StaplerResponse2 response) throws Exception {


src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/Diagnostics.java


    @Override
-    public ContextMenu doChildrenContextMenu(StaplerRequest request, StaplerResponse response) throws Exception {
+    public ContextMenu doChildrenContextMenu(StaplerRequest2 request, StaplerResponse2 response) throws Exception {


src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/Diagnostics.java


    @Override
-    public ContextMenu doContextMenu(StaplerRequest request, StaplerResponse response) throws Exception {
+    public ContextMenu doContextMenu(StaplerRequest2 request, StaplerResponse2 response) throws Exception {


src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/Diagnostics.java


    @Override
-    public ContextMenu doContextMenu(StaplerRequest request, StaplerResponse response) throws Exception {
+    public ContextMenu doContextMenu(StaplerRequest2 request, StaplerResponse2 response) throws Exception {


src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/Diagnostics.java

     * @see #isDebugMode()
     */
-    public void doTriggerDebugEvent(StaplerRequest request, StaplerResponse response) throws IOException {
+    public void doTriggerDebugEvent(StaplerRequest2 request, StaplerResponse2 response) throws IOException {


src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/diagnostics/Diagnostics.java

     * @see #isDebugMode()
     */
-    public void doTriggerDebugEvent(StaplerRequest request, StaplerResponse response) throws IOException {
+    public void doTriggerDebugEvent(StaplerRequest2 request, StaplerResponse2 response) throws IOException {


panicking · 2025-07-25T18:31:59Z

@strangelookingnerd I have rebased here and add one patch #518

rsandell · 2025-09-19T08:34:38Z

Cannot invoke "hudson.ExtensionList.isEmpty()" because "strategies" is null

I've seen this error someplace before, has to do with a bad mock I think.

rsandell · 2025-09-19T08:37:00Z

The tests that are timing out seems to all have the same symptoms, perhaps something has changed that is making the ssh mock server not working?

strangelookingnerd · 2025-09-29T14:23:25Z

@rsandell @panicking I have pushed some workarounds for the failing tests in 65ccdc6. I could not verify all of them locally, let's see what CI has to say about it.

rsandell · 2025-09-30T13:58:24Z

The maven proxy had a hickup, rebuilding...

...a/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritProjectListUpdaterFunctionalTest.java

src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/LockedDownGerritEventTest.java

...est/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java

rsandell · 2025-09-30T14:37:18Z

I am getting that bouncy castle download error on another plugin build as well.

rsandell · 2025-10-04T15:47:16Z

bc download error fixed, test timeouts still happening though.

strangelookingnerd · 2025-10-04T16:15:06Z

bc download error fixed, test timeouts still happening though.

I'll try and look into those as well.

rsandell · 2025-10-20T18:04:26Z

...in/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java

         */
        public synchronized Entry[] getEntries() {
-            return list.toArray(new Entry[list.size()]);
+            return list.toArray(new Entry[0]);


Why? Has something changed in the toArray calls to nmake the empty array arg be more efficient suddenly?

There are two styles to convert a collection to an array:

* A pre-sized array, for example, c.toArray(new String[c.size()]) * An empty array, for example, c.toArray(new String[0])

In older Java versions, using a pre-sized array was recommended, as the reflection call necessary to create an array of proper size was quite slow.

However, since late updates of OpenJDK 6, this call was intrinsified, making the performance of the empty array version the same, and sometimes even better, compared to the pre-sized version. Also, passing a pre-sized array is dangerous for a concurrent or synchronized collection as a data race is possible between the size and toArray calls. This may result in extra nulls at the end of the array if the collection was concurrently shrunk during the operation.

https://www.jetbrains.com/help/inspectopedia/ToArrayCallWithZeroLengthArrayArgument.html

That dated me pretty bad 🤣

New version also needed for new language level.

rsandell · 2025-10-21T00:37:59Z

I've fixed all tests and checkstyle warnings.
The problem with the test timeouts was because mina changed how it wanted to stop the server, and in all previous versions one of the commands where just hanging forever by design, that needed to be fixed.

…r-plugin into migrate

Maybe it'll help

rsandell · 2025-10-21T13:51:32Z

Ugh, it's one of those "works on my machine but not on CI" test problems 🤯 .

strangelookingnerd added 2 commits April 24, 2025 12:12

Require 2.479.3 or newer

17ef9b2

Cleanup, use java 17 features, reduce usage of deprecated methods

819b8e7

strangelookingnerd changed the title ~~Migrate~~ Require Jenkins 2.479.3 or newer and Jakarta EE 9 Apr 24, 2025

rsandell approved these changes Apr 25, 2025

View reviewed changes

rsandell added the chore label Apr 25, 2025

strangelookingnerd requested a review from rsandell June 12, 2025 11:54

Merge branch 'master' into migrate

2737dc6

github-advanced-security bot found potential problems Jun 26, 2025

View reviewed changes

rsandell approved these changes Jun 26, 2025

View reviewed changes

Merge branch 'master' into migrate

acf404f

rsandell approved these changes Sep 19, 2025

View reviewed changes

Workarounds for failing tests

65ccdc6

panicking suggested changes Sep 30, 2025

View reviewed changes

rsandell reviewed Oct 20, 2025

View reviewed changes

strangelookingnerd and others added 3 commits October 20, 2025 21:09

Merge branch 'master' into migrate

da6f92d

Fix SshdServerMock.stop timeouts

d91158f

Fix checkstyle.

a5ec6c6

New version also needed for new language level.

Merge branch 'migrate' of github.com:strangelookingnerd/gerrit-trigge…

6177c26

…r-plugin into migrate

rsandell requested a review from panicking October 21, 2025 00:45

Try to increase the command timeout.

7974fa5

Maybe it'll help

rsandell added the dependencies label Oct 21, 2025

Build log for debugging

af1ac21

Require Jenkins 2.479.3 or newer and Jakarta EE 9 #516

Are you sure you want to change the base?

Require Jenkins 2.479.3 or newer and Jakarta EE 9 #516

Uh oh!

Conversation

strangelookingnerd commented Apr 24, 2025