Skip to content

Run GitClientTest.testSparseCheckoutWithCliGitLFS when credentials available#1337

Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom
MarkEWaite:use-credential-for-lfs-checkout-test
Sep 8, 2025
Merged

Run GitClientTest.testSparseCheckoutWithCliGitLFS when credentials available#1337
MarkEWaite merged 1 commit intojenkinsci:masterfrom
MarkEWaite:use-credential-for-lfs-checkout-test

Conversation

@MarkEWaite
Copy link
Copy Markdown
Contributor

Run GitClientTest.testSparseCheckoutWithCliGitLFS when credentials available

The test fails in nearly 100% of cases when credentials are not provided, even though the repository is a public repository. When credentials are provided, the test only fails in about 20% of the cases. The credentials I use for the test are narrowly scoped to exactly one repository and to only allow access to repository content. Since the repository content is already publicly readable, the credential does not grant any additional permissions.

The ci.jenkins.io agents do not have the credential, so they will not run the test.

Testing done

Confirmed that test fails consistently without credentials.

Confirmed that test fails in approximately 20% of cases when I use a range of agents including:

  • Debian 11
  • Debian 12
  • Debian Testing
  • openSUSE 15.6
  • Red Hat Enterprise Linux 8
  • Rocky Linux 9
  • Ubuntu 22
  • Ubuntu 24
  • Windows

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

…ailable

The test fails in nearly 100% of cases when credentials are not provided,
even though the repository is a public repository.  When credentials are
provided, the test only fails in about 20% of the cases.  The credentials
I use for the test are narrowly scoped to exactly one repository and to
only allow access to repository content.  Since the repository content is
already publicly readable, the credential does not grant any additional
permissions.

The ci.jenkins.io agents do not have the credential, so they will not
run the test.

Testing done

Confirmed that test fails consistently without credentials.

Confirmed that test fails in approximately 20% of cases when I use a
range of agents including:

* Debian 11
* Debian 12
* Debian Testing
* openSUSE 15.6
* Red Hat Enterprise Linux 8
* Rocky Linux 9
* Ubuntu 22
* Ubuntu 24
* Windows
@MarkEWaite MarkEWaite added the tests Automated test addition or improvement label Sep 8, 2025
@MarkEWaite MarkEWaite requested a review from a team as a code owner September 8, 2025 03:41
@MarkEWaite MarkEWaite merged commit 3a4021b into jenkinsci:master Sep 8, 2025
18 checks passed
@MarkEWaite MarkEWaite deleted the use-credential-for-lfs-checkout-test branch September 8, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Automated test addition or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant