Skip to content

Use system temporary directory for known_hosts file #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 1 commit into from
Dec 16, 2025
Merged

Use system temporary directory for known_hosts file #1709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2130,7 +2130,10 @@
userName = sshUser.getUsername();
}
passphrase = createPassphraseFile(sshUser);
knownHostsTemp = createTempFile("known_hosts", "");
/* ssh.exe 9.5 on Windows does not accept spaces in path to known_hosts.
* Use temp file wrapper location because known_hosts is not sensitive info.
*/
knownHostsTemp = createTempFileForWrapper("known_hosts", "");

Check warning on line 2136 in src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line 

Line 2136 is not covered by tests
if (launcher.isUnix()) {
ssh = createUnixGitSSH(key, userName, knownHostsTemp);
askpass = createUnixSshAskpass(sshUser, passphrase);
Expand Down
Loading