Regex is not the same as Pattern, better to check input than output#9
Open
otradovec wants to merge 2 commits intojenkinsci:masterfrom
Open
Regex is not the same as Pattern, better to check input than output#9otradovec wants to merge 2 commits intojenkinsci:masterfrom
otradovec wants to merge 2 commits intojenkinsci:masterfrom
Conversation
Member
|
Thank you for your contribution. |
Author
|
@runzexia "keep some methods for compatibility" that is a good point, could You specify the methods? I would really appreciate add bit more detail about how to configure the plugin. That would help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regex is not the same as Pattern see: https://www.tutorialspoint.com/javaregex/javaregex_pattern_compile.htm
Better to check input regex from user before storing than after in get method.
I also wonder if it works on Jenkins 2.190, I would appreciate screenshot of place in configuration where i should set it. @runzexia @vjuranek