Skip to content

Regex is not the same as Pattern, better to check input than output#9

Open
otradovec wants to merge 2 commits intojenkinsci:masterfrom
otradovec:regex
Open

Regex is not the same as Pattern, better to check input than output#9
otradovec wants to merge 2 commits intojenkinsci:masterfrom
otradovec:regex

Conversation

@otradovec
Copy link
Copy Markdown

Regex is not the same as Pattern see: https://www.tutorialspoint.com/javaregex/javaregex_pattern_compile.htm
Better to check input regex from user before storing than after in get method.
I also wonder if it works on Jenkins 2.190, I would appreciate screenshot of place in configuration where i should set it. @runzexia @vjuranek

@runzexia
Copy link
Copy Markdown
Member

runzexia commented Jan 4, 2020

Thank you for your contribution.
This plugin works on jenkins 2.190.
I don't understand the difference between pattern and regex, maybe regex will understand better?
However, I think I should keep some methods for compatibility with previous versions of the plugin (maybe users will use groovy to initialize the plugin)

@otradovec
Copy link
Copy Markdown
Author

otradovec commented Jan 4, 2020

@runzexia "keep some methods for compatibility" that is a good point, could You specify the methods? I would really appreciate add bit more detail about how to configure the plugin. That would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants