plugin doesn't detect a non zero exit status returned from minion cmd.run function

[zerthimon]

Salt detects this well:

root@master:~# salt minion cmd.run 'true 1'
minion:
root@master:~# echo $?
0
root@master:~# salt minion cmd.run 'false 1'
minion:
ERROR: Minions returned with non-zero exit code
root@master:~# echo $?
11
root@master:~#

The plugin doesn't detect the error and continues the job.
It would rock if plugin detects this situation and fails the job (or not ? config parameter ?)

[mchugh19]

Thanks for reporting. I'll get on it

[mchugh19]

Hmmm. It appears this isn't exposed through the salt-api.

Here's the output from cmd.run 'false 1':

{
    "return": [
        {
            "web1": ""
        }
    ]
}

So first we'll need salt-api updated as mentioned in saltstack/salt/issues/18510

[zerthimon]

So, salt CLI command receives the exit status from minion and exits correctly, but salt-api doesn't expose it to the caller, right?

[mchugh19]

Yep. It looks that way. At least for 2015.8.8

[mchugh19]

The salt-api has been enhanced with the 2017.7 release, and this will be supported in the next release of the Jenkins plugin.

[zerthimon]

Hell yeah !!!

[mchugh19]

This was corrected in the 3.2.0 release. It should be available within the next 24 hours.