FIX: Validate time-string attribute#4
Merged
jerdra merged 3 commits intoenh/config-adaptersfrom Mar 30, 2022
Merged
Conversation
jerdra
force-pushed
the
fix/validate-timestring-attribute
branch
from
99dfad2 to
5490b56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small fix implemented that ensures that the DRMAA API can receive a time-string formatted as (X.XXX:XX:XX or XX:XX) rather than enforcing an integer.
Currently this has been tested on the slurm-drmaa API, however it is possible other APIs require an integer value. This requires testing and possibly writing DRM-specific patches