You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I've made some modifications to reduce memory consumption when creating sketches for the differential builder.
More precisely, I made the following modifications:
Removed iterators allocation (filtered_colors) during sketches construction for differential indexes.
Added reserve for colors ids vector.
Changed function signature to accept an index.
Moved calculation of total load inside the first loop.
Yes, I have tested it, but only with the --diff option and not the --meta option. The rest of the command is the same.
Please let me know if you encounter any issues!
Ok, thanks for confirming. Then try it also on the test files in test_data, just to make sure it correctly handles small collections as well. @Alessio-Campa Have you tried it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've made some modifications to reduce memory consumption when creating sketches for the differential builder.
More precisely, I made the following modifications: