Truncate existing temp file in meta_partition constructor#93
Merged
jermp merged 1 commit intojermp:masterfrom Oct 6, 2025
Merged
Truncate existing temp file in meta_partition constructor#93jermp merged 1 commit intojermp:masterfrom
jermp merged 1 commit intojermp:masterfrom
Conversation
Ensure the temp file is truncated if it exists.
Contributor
Author
|
Might make sense to also add a cleanup to whatever place in the code where it's no longer needed? UPD: On further inspection, I see that you do clean up with |
Owner
|
Ok, makes sense, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the temp file is truncated if it exists. Otherwise, repeated independent runs would add lines to the same file, and it isn't detected when the files are read later on, leading to "seed didn't work" exceptions.