Skip to content

Followup to savegame notifications#16

Open
lologarithm wants to merge 9 commits intojerold:masterfrom
lologarithm:savegames
Open

Followup to savegame notifications#16
lologarithm wants to merge 9 commits intojerold:masterfrom
lologarithm:savegames

Conversation

@lologarithm
Copy link
Copy Markdown
Collaborator

This starts to hook the net code into the real lifecycle of the application.

@jerold
Copy link
Copy Markdown
Owner

jerold commented Nov 3, 2016

Wondering how to do Roads. Those pieces don't live on a plot, but between two plots. Could come up with a system of each plot/tile owning one of its edges, so if the Piece is a Road, then we use it's coordinate to get a plot/tile, and then get the edge it "owns". Then math a bit to see which two plots the the edge actually bridges... Or we add a CoordinateType to the ng model, and on Coordinate set a type and two sets of xy values. Plot or Tile, we use the first set only to generate a key. Road, we use both sets to generate a key.

@jerold
Copy link
Copy Markdown
Owner

jerold commented Nov 3, 2016

Can't use the Cube object to replace Coordinate. Forgot that this game has plots and edges, and the Cube Hex doesn't really address corners in it's coordinate system. :/

Comment thread lib/catannet.dart

class DartClient {
Client _client;
Stream events;
Copy link
Copy Markdown
Owner

@jerold jerold Nov 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stream get events => eventController.stream;

?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose L44 does the same thing.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could do it either way, as long as we always make sure eventController is non-null before the getter is invoked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants