-
Notifications
You must be signed in to change notification settings - Fork 691
Make test262-harness.py Python 3-compatible #4381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test262-harness.py Python 3-compatible #4381
Conversation
f8274fc to
63d7dae
Compare
|
Note that this is another py 2vs3 issue: |
Yeap, I am using python3 to running the script, python2 are on the way to gone |
63d7dae to
c6dd967
Compare
akosthekiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (note that I've edited the commit message as a maintainer and force-pushed)
|
For the records, the following traceback was in the original commit message: |
|
LGTM (informal) |
|
Please rebase. |
Less operator is not supported between int and None in Python 3. Fix that Python 2 legacy in test262-harness.py. JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
c6dd967 to
f0ea29e
Compare
|
rebased |
rerobika
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
indent are using to do arithmetic compare
leading < indent, and None can't do that.JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com