Handling encoding errors for python3 properly #4486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lygstate
force-pushed
the
encoding_python3
branch
from
2d82c23 to
47445bd
Compare
```
Build command:
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\build.py \
--lto=off \
--profile=es.next \
--debug \
--stack-limit=96 \
--gc-mark-limit=16 \
--mem-stress-test=on \
--builddir=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es.next-debug \
--install=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es.next-debug\local
Test command:
TZ='UTC' \
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\runners/run-test-suite.py \
--engine \
C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es.next-debug\local\bin\jerry.exe \
--test-dir \
C:\work\study\languages\typescript\jerryscript\tests/jerry \
-q \
--skip-list=es5.1\
[ 237/1145] FAIL (3): tests\jerry\es.next\module-resource-name.js
================================================
Script Error: assertion failed
================================================
[summary] build\tests\jerry_tests-es.next-debug\local\bin\jerry.exe tests\jerry
TOTAL: 1145
PASS: 1144
FAIL: 1
Success: 99%
Build command:
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\build.py \
--lto=off \
--profile=es5.1 \
--stack-limit=96 \
--gc-mark-limit=16 \
--builddir=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1 \
--install=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1\local
Test command:
TZ='UTC' \
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\runners/run-test-suite.py \
--engine \
C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1\local\bin\jerry.exe \
--test-dir \
C:\work\study\languages\typescript\jerryscript\tests/jerry \
-q \
--skip-list=es.next\
[summary] build\tests\jerry_tests-es5.1\local\bin\jerry.exe tests\jerry
TOTAL: 543
PASS: 543
FAIL: 0
Success: 100%
Build command:
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\build.py \
--lto=off \
--profile=es5.1 \
--snapshot-save=on \
--snapshot-exec=on \
--jerry-cmdline-snapshot=on \
--stack-limit=96 \
--gc-mark-limit=16 \
--builddir=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-snapshot \
--install=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-snapshot\local
Test command:
TZ='UTC' \
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\runners/run-test-suite.py \
--engine \
C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-snapshot\local\bin\jerry.exe \
--test-dir \
C:\work\study\languages\typescript\jerryscript\tests/jerry \
-q \
--skip-list=es.next\ \
--snapshot
Traceback (most recent call last):
File "C:\work\study\languages\typescript\jerryscript\tools\runners\run-test-suite.py", line 214, in <module>
sys.exit(main(get_arguments()))
File "C:\work\study\languages\typescript\jerryscript\tools\runners\run-test-suite.py", line 105, in main
passed = run_snapshot_tests(args, tests)
File "C:\work\study\languages\typescript\jerryscript\tools\runners\run-test-suite.py", line 178, in run_snapshot_tests
(returncode, stdout) = execute_test_command(generate_snapshot_cmd + [test])
File "C:\work\study\languages\typescript\jerryscript\tools\runners\run-test-suite.py", line 88, in execute_test_command
stdout = process.communicate()[0]
File "C:\Python38\lib\subprocess.py", line 1011, in communicate
stdout = self.stdout.read()
File "C:\Python38\lib\encodings\unicode_escape.py", line 26, in decode
return codecs.unicode_escape_decode(input, self.errors)[0]
UnicodeDecodeError: 'unicodeescape' codec can't decode bytes in position 70-71: truncated \uXXXX escape
Build command:
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\build.py \
--lto=off \
--profile=es5.1 \
--debug \
--stack-limit=96 \
--gc-mark-limit=16 \
--mem-stress-test=on \
--builddir=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug \
--install=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug\local
Test command:
TZ='UTC' \
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\runners/run-test-suite.py \
--engine \
C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug\local\bin\jerry.exe \
--test-dir \
C:\work\study\languages\typescript\jerryscript\tests/jerry \
-q \
--skip-list=es.next\
[summary] build\tests\jerry_tests-es5.1-debug\local\bin\jerry.exe tests\jerry
TOTAL: 543
PASS: 543
FAIL: 0
Success: 100%
Build command:
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\build.py \
--lto=off \
--profile=es5.1 \
--snapshot-save=on \
--snapshot-exec=on \
--jerry-cmdline-snapshot=on \
--debug \
--stack-limit=96 \
--gc-mark-limit=16 \
--builddir=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug-snapshot \
--install=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug-snapshot\local
Test command:
TZ='UTC' \
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\runners/run-test-suite.py \
--engine \
C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug-snapshot\local\bin\jerry.exe \
--test-dir \
C:\work\study\languages\typescript\jerryscript\tests/jerry \
-q \
--skip-list=es.next\ \
--snapshot
Traceback (most recent call last):
File "C:\work\study\languages\typescript\jerryscript\tools\runners\run-test-suite.py", line 214, in <module>
sys.exit(main(get_arguments()))
File "C:\work\study\languages\typescript\jerryscript\tools\runners\run-test-suite.py", line 105, in main
passed = run_snapshot_tests(args, tests)
File "C:\work\study\languages\typescript\jerryscript\tools\runners\run-test-suite.py", line 178, in run_snapshot_tests
(returncode, stdout) = execute_test_command(generate_snapshot_cmd + [test])
File "C:\work\study\languages\typescript\jerryscript\tools\runners\run-test-suite.py", line 88, in execute_test_command
stdout = process.communicate()[0]
File "C:\Python38\lib\subprocess.py", line 1011, in communicate
stdout = self.stdout.read()
File "C:\Python38\lib\encodings\unicode_escape.py", line 26, in decode
return codecs.unicode_escape_decode(input, self.errors)[0]
UnicodeDecodeError: 'unicodeescape' codec can't decode bytes in position 70-71: truncated \uXXXX escape
Build command:
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\build.py \
--lto=off \
--profile=es5.1 \
--debug \
--stack-limit=96 \
--gc-mark-limit=16 \
--cpointer-32bit=on \
--mem-heap=1024 \
--builddir=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug-cpointer_32bit \
--install=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug-cpointer_32bit\local
Test command:
TZ='UTC' \
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\runners/run-test-suite.py \
--engine \
C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug-cpointer_32bit\local\bin\jerry.exe \
--test-dir \
C:\work\study\languages\typescript\jerryscript\tests/jerry \
-q \
--skip-list=es.next\
[summary] build\tests\jerry_tests-es5.1-debug-cpointer_32bit\local\bin\jerry.exe tests\jerry
TOTAL: 543
PASS: 543
FAIL: 0
Success: 100%
Build command:
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\build.py \
--lto=off \
--profile=es5.1 \
--debug \
--stack-limit=96 \
--gc-mark-limit=16 \
--external-context=on \
--builddir=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug-external_context \
--install=C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug-external_context\local
Test command:
TZ='UTC' \
cmd \
/S \
/C \
C:\work\study\languages\typescript\jerryscript\tools\runners/run-test-suite.py \
--engine \
C:\work\study\languages\typescript\jerryscript\build\tests\jerry_tests-es5.1-debug-external_context\local\bin\jerry.exe \
--test-dir \
C:\work\study\languages\typescript\jerryscript\tests/jerry \
-q \
--skip-list=es.next\
[summary] build\tests\jerry_tests-es5.1-debug-external_context\local\bin\jerry.exe tests\jerry
TOTAL: 543
PASS: 543
FAIL: 0
```
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
Contributor
Author
|
Close in favor of #4390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com