Fix stdout encoding for python2 and python3 in test262-harness.py #4499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
Traceback (most recent call last):
File "C:\work\study\languages\typescript\jerryscript\tools\runners\test262-harness.py", line 1019, in <module>
sys.exit(main())
File "C:\work\study\languages\typescript\jerryscript\tools\runners\test262-harness.py", line 1009, in main
code = test_suite.run(options.command, args,
File "C:\work\study\languages\typescript\jerryscript\tools\runners\test262-harness.py", line 930, in run
progress.has_run(result)
File "C:\work\study\languages\typescript\jerryscript\tools\runners\test262-harness.py", line 753, in has_run
result.report_outcome(True)
File "C:\work\study\languages\typescript\jerryscript\tools\runners\test262-harness.py", line 492, in report_outcome
self.write_output(sys.stdout)
File "C:\work\study\languages\typescript\jerryscript\tools\runners\test262-harness.py", line 506, in write_output
target.write("--- errors --- \n %s" % error)
UnicodeEncodeError: 'gbk' codec can't encode character '\xab' in position 52: illegal multibyte sequence
...............................................=== Summary - updating excludelist ===
```
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
Member
Contributor
Author
Member
|
Let's start with this PR and #4492 . What's the difference between them? They contains the exact same changes. |
Contributor
Author
Oh sorry, mis created pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com