Skip to content

Add shortcut (Ctrl+L) to clear logs #460

Open
sunny-Ne5 wants to merge 1 commit into
jesseduffield:masterfrom
sunny-Ne5:master
Open

Add shortcut (Ctrl+L) to clear logs #460
sunny-Ne5 wants to merge 1 commit into
jesseduffield:masterfrom
sunny-Ne5:master

Conversation

@sunny-Ne5
Copy link
Copy Markdown

@sunny-Ne5 sunny-Ne5 commented Jul 19, 2023

Fix #403

@sunny-Ne5 sunny-Ne5 changed the title Fix #403: Clear logs Add shortcut (Ctrl+L) to clear logs Jul 19, 2023
@jesseduffield
Copy link
Copy Markdown
Owner

Looking good. Two things:

  • Could we make this keybinding also available in the side views that render to the main view? I'd prefer to not have to hit enter in order to press ctrl+l
  • Looks like the keybinding isn't rendered properly in the keybindings menu (which you get upon pressing '?'
image

Looks like we need to add a special key to the switch statement in GetKey() in pkg/gui/keybindings.go

@sunny-Ne5
Copy link
Copy Markdown
Author

  • Could we make this keybinding also available in the side views that render to the main view? I'd prefer to not have to hit enter in order to press ctrl+l

Should we enable this keybinding for "Containers" or for other side views as well? For this I was planning to add one more entry to GetInitialKeybindings() in keybindings.go. Let me know if there is a better way to do it if it's repetitive.

*Looks like the keybinding isn't rendered properly in the keybindings menu (which you get upon pressing '?'
Is this good?
image

@jesseduffield
Copy link
Copy Markdown
Owner

@sunny-Ne5 Sorry for the late reply! You'll only need the keybinding for containers and services, so feel free to just add an extra two keybindings for that

@peauc
Copy link
Copy Markdown
Contributor

peauc commented Jun 15, 2024

I want to take a look at this PR to move it forward.
@sunny-Ne5, are you still interested in this PR, you don't mind ?

@sunny-Ne5
Copy link
Copy Markdown
Author

sunny-Ne5 commented Jun 16, 2024 via email

@peauc peauc mentioned this pull request Jun 16, 2024
@peauc
Copy link
Copy Markdown
Contributor

peauc commented Jun 16, 2024

I've pulled your changed and have started a branch 👍. Thanks

@peauc
Copy link
Copy Markdown
Contributor

peauc commented Jun 16, 2024

@jesseduffield requested changes have been made in my pull request 👍

@obfox
Copy link
Copy Markdown

obfox commented Nov 26, 2025

Do you added this feature on different branch?

@peauc
Copy link
Copy Markdown
Contributor

peauc commented Nov 26, 2025

@obfox hello, sadly the repo is not maintained. All pull requests are merged on my personal fork if you want to get a build with a few fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear logs

4 participants