Fix color contrast for better readability on dark backgrounds#725
Open
charemma wants to merge 1 commit into
Open
Fix color contrast for better readability on dark backgrounds#725charemma wants to merge 1 commit into
charemma wants to merge 1 commit into
Conversation
charemma
force-pushed
the
fix/color-contrast-685
branch
from
ca711c0 to
5a7fc71
Compare
Changed FgBlue to FgCyan in multiple locations to improve text visibility on terminals with dark blue ANSI colors. This affects image history display, service status indicators, container states, keyboard shortcuts, and command output. Fixes jesseduffield#685
charemma
force-pushed
the
fix/color-contrast-685
branch
from
5a7fc71 to
a0819d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved text readability on terminals with dark ANSI blue colors by changing FgBlue to FgCyan in a few places.
I noticed this while using lazydocker with a terminal theme that has dark blue (like the standard ANSI #0000AA). The blue text was pretty hard to read on black backgrounds - especially the keyboard shortcuts at the bottom and some status indicators.
Changed the following to use cyan instead:
<missing>IDs and0BsizesnonestatusrestartingstateTested it with both the dark blue theme and normal themes - cyan has way better contrast and doesn't hurt readability on any setup.
Fixes #685