fix: use DiskUsage instead of VolumeList to populate Volume.UsageData#746
Open
glav-git wants to merge 1 commit into
Open
fix: use DiskUsage instead of VolumeList to populate Volume.UsageData#746glav-git wants to merge 1 commit into
DiskUsage instead of VolumeList to populate Volume.UsageData#746glav-git wants to merge 1 commit into
Conversation
Volume.UsageData
Volume.UsageDataDiskUsage instead of VolumeList to populate Volume.UsageData
2bbeb7a to
f74d4bd
Compare
f74d4bd to
b06f7d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #450
Explanation:
The renderer of volumes list already had support for displaying
Volume.UsageData:lazydocker/pkg/gui/volumes_panel.go
Lines 80 to 83 in 577797d
But it was never displayed, since according to
Volume.UsageDatafield comment it was available only when using/system/dfendpoint:lazydocker/vendor/github.com/docker/docker/api/types/volume/volume.go
Lines 56 to 75 in 577797d
Since
DiskUsagereturns literally the sameVolumetype asVolumeList- I was able to simply swap method calls (and add option to fetch only volumes data) and was proud to finally seeSizeandRefCountof my docker volume.Before
After