fix: sanitize subprocess call in client.go#798
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
vendor/github.com/docker/docker-credential-helpers/client/client.go.Vulnerability
V-001vendor/github.com/docker/docker-credential-helpers/client/client.go:49Description: The Docker credential helper client passes the serverURL value directly into cmd.Input() at client.go lines 49 and 78 using strings.NewReader(serverURL) without any sanitization or validation. The Shell helper's Input() method at command.go:52 accepts this data and feeds it to the credential helper subprocess via stdin. If the serverURL originates from user-controlled input such as a git remote URL or Docker registry configuration file, an attacker can craft a malicious serverURL containing newline characters or shell metacharacters. Depending on the underlying credential helper implementation, injected newlines may cause the helper to interpret additional lines as separate protocol messages or shell commands, potentially executing attacker-controlled operations on the host.
Changes
vendor/github.com/docker/docker-credential-helpers/client/client.goVerification
Automated security fix by OrbisAI Security