feat: show container name alongside service name when different#802
Open
Scolliq wants to merge 1 commit into
Open
feat: show container name alongside service name when different#802Scolliq wants to merge 1 commit into
Scolliq wants to merge 1 commit into
Conversation
When a service has a custom container_name set in docker-compose.yml that differs from the service name, the Services panel now shows both: frontend (web_app) instead of just: frontend Fixes jesseduffield#40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40.
Why: When a service in
docker-compose.ymlhas acontainer_nameset that differs from the service name, the Services panel only shows the service name. Users who set custom container names have no way to see them at a glance.What changed: In
GetServiceDisplayStrings, if the container's actual name differs from the service name, the display string becomesservice (container)— e.g.frontend (web_app). When the names are the same (the common case), nothing changes.Before:
After (with container_name set in docker-compose.yml):