fix(unbound-method): fix issue 1800

[eryue0220]

Fix: #1800

[G-Rath]

at this point I feel like this is an overly complicated solution - have you looked into why our existing logic for handling jest.mocked isn't catching this case?

[eryue0220]

at this point I feel like this is an overly complicated solution - have you looked into why our existing logic for handling jest.mocked isn't catching this case?

Sorry for the response, in this case the jest.mocked will be early returned in this if statement. A more easier way is to add condition that is lastLink !== 'mocked'. But I'm not sure this change is safe enough, so I tried a new way.

[G-Rath]

I still would expect we can identify the call with parseJestFn, but what you've got it a lot simpler than what you had before and finding the right node to parse can be a pain at times, so I'm happy to go with this once you've simplified it a bit more with the isSupportedAccessor change

[G-Rath]

isSupportedAccessor takes an optional value as its second param for just these situations - so rather than having to do the work twice, you can just do isSupportedAccessor(..., 'jest')

that in turn means you should be able to refactor this all to be a return

[G-Rath]

Suggested change

	// Also try using parseJestFnCall as a fallback
	// const jestFnCall = parseJestFnCall(
	// findTopMostCallExpression(parentCall),
	// context,
	// );
	// return (
	// jestFnCall?.type === 'jest' &&
	// jestFnCall.members.length >= 1 &&
	// isIdentifier(jestFnCall.members[0], 'mocked')
	// );

[G-Rath]

this is the opposite of the check we do later on, so ideally we can merge the two but that might be messy due to the optional chaining and require an else which I try to avoid so not too fussed to keep it like this for now