Remove jetstack-agent chart + docs #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think most of the jetstack-agent stuff has been removed and is no longer relevant to what we do day-to-day. This is a first step towards cleaning up the code base so we can refactor further. There are several references in README to Jetstack secure, to the old chart, and to stuff that's no longer relevant, so I've cleaned it up a lot. I also moved the release guide to RELEASE.md to match what we do in other projects, and cleaned up the release info to be a bit more readable and focus on details that are important to us. To preserve the old Jetstack Secure functionality in the event we require it, I've already created + pushed a tag called "before-jetstack-secure-removal". If we need to do something Jetstack Secure related (such as an agent change or a chart tweak) we can create a branch from that tag and maintain that separately. Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think most of the jetstack-agent stuff has been removed and is no longer relevant to what we do day-to-day. This is a first step towards cleaning up the code base so we can refactor further.
There are several references in README to Jetstack secure, to the old chart, and to stuff that's no longer relevant, so I've cleaned it up a lot.
I also moved the release guide to RELEASE.md to match what we do in other projects, and cleaned up the release info to be a bit more readable and focus on details that are important to us.
I deleted the "Tiers" section, because I think that belongs in enterprise docs and not here. It'll just get out of date here.
New Tag
To preserve the old Jetstack Secure functionality in the event we require it, I've already created + pushed a tag called
"before-jetstack-secure-removal".
If we need to do something Jetstack Secure related (such as an agent change or a chart tweak) we can create a branch from that tag and maintain that separately.