[VC-43753] CyberArk Discovery and Context: Use sha3 checksum in snapshot-links API request#686
Merged
wallrj-cyberark merged 1 commit intomasterfrom Aug 14, 2025
Merged
Conversation
Signed-off-by: Richard Wall <richard.wall@venafi.com>
wallrj-cyberark
commented
Aug 13, 2025
| if err := decoder.Decode(&req); err != nil { | ||
| http.Error(w, `{"error": "Invalid request format"}`, http.StatusBadRequest) | ||
| return | ||
| } |
Member
Author
There was a problem hiding this comment.
This makes the mock server respond more like the real server.
Contributor
|
/approve |
inteon
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test was failing because the request body format for the snapshot-links API has been changed, to accept a sha3 checksum instead of a sha256 checksum.
I've updated the dataupload client accordingly.
Part of: https://venafi.atlassian.net/browse/VC-43753
Related PRs
Testing
Before:
After: