[VC-43753] Collect creationTimestamp, deletionTimestamp and resourceVersion metadata for Secret and Route resources#688
Merged
wallrj-cyberark merged 1 commit intomasterfrom Aug 19, 2025
Conversation
…ollected metadata Signed-off-by: Richard Wall <richard.wall@venafi.com>
SgtCoDFish
approved these changes
Aug 19, 2025
Contributor
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Love the extra comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CyberArk Discovery and Context API team requested the creationTimestamp and resourceVersion for Secret resources.
I assume the TLSPK backend does not need this metadata, but it seems harmless to add it.
I also added deletionTimestamp, because I expect the CyberArk API will eventually want that too.
And I added these new metadata fields to the Route handling, for consistency.
Secret and Route are the only two resources where the fields are allow-listed.
All other resources are pushed to the backend in-full, including all the metadata fields.
I think it would be more consistent if we published the same metadata fields for all resources, and I've tried to express that in some new function comments.
Part of: https://venafi.atlassian.net/browse/VC-43753
Testing
You can see the extra fields that are collected as follows:
I collected two sample output files using code from master (before) and from this branch (after) and then diffed them
go run . agent \ --install-namespace venafi \ --api-token unused \ --one-shot \ --agent-config-file examples/one-shot-secret.yaml \ --output-path=before.json