[VC-43403] Revert some of the MachineHub changes from #653#694
Merged
wallrj-cyberark merged 1 commit intomasterfrom Aug 22, 2025
Merged
[VC-43403] Revert some of the MachineHub changes from #653#694wallrj-cyberark merged 1 commit intomasterfrom
wallrj-cyberark merged 1 commit intomasterfrom
Conversation
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj-cyberark
changed the title
inteon
approved these changes
Aug 22, 2025
maelvls
reviewed
Aug 22, 2025
| // CredentialsSecretName is the name of a Kubernetes Secret in the same | ||
| // namespace as the agent, which will be watched for a username and password | ||
| // to send to CyberArk Identity for authentication. | ||
| CredentialsSecretName string `yaml:"credentialsSecretName"` |
Member
There was a problem hiding this comment.
I agree, not sure why we went with loading the credentials from a Kubernetes secret.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to revert some of the code which @maelvls introduced in #653 because I'm finding it really difficult to work with.
Specifically,
TLSPKModeto be calledOutputMode, orOutputsand add aLocalFilemode. Then we can just build a list of output functions, depending on what command line flags have been supplied and call them all in a batch, periodically, or one-shot.client.Clienttooutput.Publisherand have a function to compose an outputter from one or more of: LocalFilePublisher, TLSPKPublisher, MachineHubPublisher.Here's what I want to do next, if this PR merges:
I explained the problems to @inteon in the standup meeting this morning, so I'll ask him to review this.