[VC-43403] CyberArk: enhance service discovery to return multiple APIs#701
Merged
wallrj-cyberark merged 1 commit intomasterfrom Aug 28, 2025
Merged
Conversation
wallrj-cyberark
changed the title
wallrj-cyberark
force-pushed
the
VC-43403-dataupload-client
branch
from
a49662f to
5bd316d
Compare
wallrj-cyberark
force-pushed
the
VC-43403-dataupload-client
branch
from
5bd316d to
3fa015d
Compare
wallrj-cyberark
force-pushed
the
VC-43403-servicediscovery-inventory-api
branch
from
ff781e3 to
b82d7ce
Compare
This was referenced Aug 28, 2025
wallrj-cyberark
force-pushed
the
VC-43403-servicediscovery-inventory-api
branch
2 times, most recently
from
31f3e37 to
78859a8
Compare
…d API - Replaced `DiscoverIdentityAPIURL` with `DiscoverServices` to fetch all service endpoints in a single call. - Updated `Services` struct to include `Identity` and `DiscoveryContext` endpoints. - Refactored dependent modules (`dataupload`, `identity`) to use the new `DiscoverServices` method. - Adjusted tests and mock server to align with the new service discovery implementation. - Removed redundant `platformDomain` logic from `dataupload_test.go`.
wallrj-cyberark
force-pushed
the
VC-43403-servicediscovery-inventory-api
branch
from
78859a8 to
1a40e3f
Compare
maelvls
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance service discovery to return multiple APIs. This allows us to also discover the URL of the discoverycontext / inventory API, so that we will no longer have to compute the URL ourselves...which is brittle if the API maintainers change the API domains or paths.
DiscoverIdentityAPIURLtoDiscoverServicesfor broader API supportServicesstruct to encapsulate multiple service endpointsDiscoverServicesmethodplatformDomainvariable indataupload_test.goFollow up PRs