Skip to content

[VC-43403] CyberArk(identity): enhance test logging and context handling #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wallrj-cyberark merged 1 commit into from
Aug 28, 2025
Merged

[VC-43403] CyberArk(identity): enhance test logging and context handling #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/internal/cyberark/identity/advance_authentication_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ import (
"fmt"
"testing"

"k8s.io/klog/v2"
"k8s.io/klog/v2/ktesting"

"github.com/jetstack/preflight/pkg/internal/cyberark/servicediscovery"

_ "k8s.io/klog/v2/ktesting/init"
)

func Test_IdentityAdvanceAuthentication(t *testing.T) {
Expand Down Expand Up @@ -97,7 +102,8 @@ func Test_IdentityAdvanceAuthentication(t *testing.T) {

for name, testSpec := range tests {
t.Run(name, func(t *testing.T) {
ctx := t.Context()
logger := ktesting.NewLogger(t, ktesting.DefaultConfig)
ctx := klog.NewContext(t.Context(), logger)

identityAPI, httpClient := MockIdentityServer(t)

Expand Down
11 changes: 8 additions & 3 deletions pkg/internal/cyberark/identity/mock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,16 @@ var (
advanceAuthenticationFailureResponse string
)

type mockIdentityServer struct{}
type mockIdentityServer struct {
t testing.TB
}

// MockIdentityServer returns a URL of a mocked CyberArk identity server and an
// HTTP client with the CA certs needed to connect to it..
func MockIdentityServer(t *testing.T) (string, *http.Client) {
mis := &mockIdentityServer{}
func MockIdentityServer(t testing.TB) (string, *http.Client) {
mis := &mockIdentityServer{
t: t,
}
server := httptest.NewTLSServer(mis)
t.Cleanup(server.Close)
httpClient := server.Client()
Expand All @@ -68,6 +72,7 @@ func MockIdentityServer(t *testing.T) (string, *http.Client) {
}

func (mis *mockIdentityServer) ServeHTTP(w http.ResponseWriter, r *http.Request) {
mis.t.Log(r.Method, r.RequestURI)
switch r.URL.String() {
case "/Security/StartAuthentication":
mis.handleStartAuthentication(w, r)
Expand Down