Relocate internal packages and update imports#704
Merged
wallrj-cyberark merged 1 commit intomasterfrom Sep 4, 2025
Merged
Conversation
- Moved `pkg/internal/` to `internal/` to align with [Go's internal package conventions](https://go.dev/doc/modules/layout#package-or-command-with-supporting-packages). - Updated all relevant import paths to reflect the new package structure. - Adjusted `make/test-unit.mk` to include the new directory structure in test coverage. - Ensured all tests and mock data are updated to work with the new structure. Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj-cyberark
force-pushed
the
top-level-internal
branch
from
2f63f81 to
da9bd2d
Compare
mladen-rusev-cyberark
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some cyberark test utils which I want to use in the
cmd/tests (#707), but can't because:pkg/internal/tointernal/to align with Go's internal package conventions.make/test-unit.mkto include the new directory structure in test coverage.