-
Notifications
You must be signed in to change notification settings - Fork 25
[VC-35565] Automate the e2e script to run in CI #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wallrj-cyberark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions for things to be addressed now or in future PRs.
* add venctl and step as tools * reduce log level * add controls based on MR labels
wallrj-cyberark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mladen-rusev-cyberark
Lets merge this and try it out and improve it in future PRs.
For example, I think we should probable add some labels to the GKE cluster so that the security team using Wiz.io can trace this back to our team and understand the purpose of the cluster.
Also have no idea how we are going to turn on coverage instrumentation in the agent binary and then copy the coverage report back from the agent running in this remote cluster.
| ## @category Testing | ||
| test-e2e-gke: | ||
| test-e2e-gke: | $(NEEDS_HELM) $(NEEDS_STEP) $(NEEDS_VENCTL) | ||
| ./hack/e2e/test.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So does makefile-modules automatically add _bin/tools to the PATH?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GCP_SA_KEYtest-e2eandkeep-e2e-cluster- one to trigger the e2e test and the other to keep the cluster alive in GKE for debugging.Closes https://venafi.atlassian.net/browse/VC-35565