Open
Conversation
vladdoster
commented
Aug 18, 2024
vladdoster
commented
- Correct punctuation mistakes
- Rephrase text to make it easier to read
- Correct punctuation mistakes - Rephrase text to make it easier to read
vladdoster
commented
Aug 18, 2024
jfrog-applications/ci-and-sdks/ci-integrations/maven-artifactory-plugin.md
Outdated
Show resolved
Hide resolved
- Remove redundant wording from changes
eyalbe4
suggested changes
Aug 19, 2024
| ``` | ||
|
|
||
| The plugin's invocation phase is validate by default, and we recommend you don't change it so the plugin is called as early as possible in the lifecycle of your Maven build. | ||
| The plugin's invocation phase is validated by default, and we recommend you don't change it so the plugin is called as early as possible in the lifecycle of your Maven build. |
Contributor
There was a problem hiding this comment.
The invitation phase is called "Validate". Perhaps it is best to make Validate a link to a Maven document describing the lifecycle phrases, to make it clearer this isn't a phrasing problem.
| | `<deployProperties>` | Specifies properties you can attach to published artifacts. For example: prop-value. | | ||
| | `<artifactory>` | Specifies whether environment variables are published as part of BuildInfo metadata and which include or exclude patterns are applied when variables are collected | | ||
| | `<publisher>` | Defines an Artifactory repository where build artifacts should be published using a combination of a `<contextUrl>` and `<repoKey>/<snapshotRepoKey>`. Build artifacts are deployed if the deploy goal is executed and only after all modules are built. | | ||
| | `<publisher>` | Defines an Artifactory repository where build artifacts should be published using a combination of a `<contextUrl>` and `<repoKey>/<snapshotRepoKey>`. Build artifacts are deployed only after the deployment goal is executed and all modules are built. | |
Contributor
There was a problem hiding this comment.
The goal is called "deploy" and therefore it shouldn't be referenced as "the deployment goal".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.