Skip to content

Conversation

@naveenku-jfrog
Copy link
Collaborator

@naveenku-jfrog naveenku-jfrog commented Oct 13, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

What: Added logic for handling input and structure.
Depend on other PRs: Yes,

Screenshot 2025-10-14 at 11 43 05 AM Screenshot 2025-10-14 at 11 43 22 AM Screenshot 2025-10-14 at 11 44 28 AM

@naveenku-jfrog naveenku-jfrog added the new feature Automatically generated release notes label Oct 13, 2025
@agrasth
Copy link
Collaborator

agrasth commented Oct 13, 2025

Here cliutils/flagkit/flags.go
why we are using xrOutput instead of Format constant, using lowercase limit instead of Limit?
ig this should be more like, can you pls verify this.

ReleaseBundleSearch: {
    Format, OrderBy, FilterBy, OrderAsc, Limit, Offset, Includes,
},
  1. We are using Uppercase because flags are inside flagkit package and we need those flags in cli package:
    rbSearchCmd := lifecycle.NewSearchGroupCommand().
    SetServerDetails(lcDetails).SetOffset(offset).SetLimit(limit).
    SetFilterBy(c.GetStringFlagValue(flagkit.FilterBy)).
    SetOrderBy(c.GetStringFlagValue(flagkit.OrderBy)).
    SetOrderAsc(c.GetBoolFlagValue(flagkit.OrderAsc)).
    SetOutputFormat(c.GetStringFlagValue(flagkit.Format))
    So, we need uppercase letter flag only.

  2. xrOutput replaced it with Format.

@agrasth
Copy link
Collaborator

agrasth commented Oct 13, 2025

here, why are we using release-bundle groups(names), why not release-bundle names?

--This is initially decided, because group api results of names + something extra. But as per requirement, we want to use names only.

@agrasth
Copy link
Collaborator

agrasth commented Oct 13, 2025

here as we are moving ahead with this approach, I feel jf rbs names -h won't show proper help. Are we handling this?

-- Sharing screenshot:
Screenshot 2025-10-14 at 2 58 05 PM

@naveenku-jfrog naveenku-jfrog merged commit c901bb8 into jfrog:main Oct 15, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants