Fix/rteco 562 jf twine incorrectly applies build properties to similar named files #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # artifactory/commands/python/twine.go
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
reshmifrog
requested changes
Dec 29, 2025
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
reshmifrog
requested changes
Dec 29, 2025
| `"name": {"$match": "%s*"}` + | ||
| `}]` + | ||
| `}]` + | ||
| `"$or": [%s]` + |
Contributor
There was a problem hiding this comment.
why are we using the or and not and logical expression?
Collaborator
Author
There was a problem hiding this comment.
Actually it can more than one files to search.
Collaborator
There was a problem hiding this comment.
I think it makes sense, it's not logical operator in aql, can we try and compare response for and vs or
artifactory/commands/python/twine.go
Outdated
| `"$or": [%s]` + | ||
| `}` | ||
| return fmt.Sprintf(itemsPart, repo, fileInitial) | ||
| sha1OrClause := strings.Join(sha1Conditions, ",") |
Collaborator
Author
There was a problem hiding this comment.
Its just appending separator between sha256 for different files.
Contributor
|
Please add a testcase as well for this covering this edge case. |
naveenku-jfrog
requested a deployment
to
frogbot
GitHub Actions
Waiting
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
fluxxBot
requested changes
Dec 29, 2025
| `"name": {"$match": "%s*"}` + | ||
| `}]` + | ||
| `}]` + | ||
| `"$or": [%s]` + |
Collaborator
There was a problem hiding this comment.
I think it makes sense, it's not logical operator in aql, can we try and compare response for and vs or
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
reshmifrog
approved these changes
Dec 30, 2025
reshmifrog
approved these changes
Dec 30, 2025
…lies-build-properties-to-similar-named-files
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
naveenku-jfrog
temporarily deployed
to
frogbot
GitHub Actions
Inactive
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Searching the uploaded artifacts by path instead of name