Feature/ruby gems support #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom packageManagerToRepositoryPackageType mapping - Remove configureRuby function from setup command - Add design documentation - Ruby support now config-only via ruby-config command
…reateGradleBuildFile function in gradle.go (not needed for Ruby) - Revert configureGradle changes in setup.go (not related to Ruby) - Keep only Ruby-specific functionality in ruby.go
…declared but never used in the code - Clean up leftover code from Ruby implementation
agrasth
force-pushed
the
feature/ruby-gems-support-2
branch
from
d0a2569 to
3568e6b
Compare
bhanurp
requested changes
Jun 20, 2025
artifactory/commands/ruby/ruby.go
Outdated
Comment on lines
102
to
108
| // CreateGemrc creates a .gemrc configuration file for authentication | ||
| func CreateGemrc(repoUrl, username, password string) error { | ||
| // TODO: Implement .gemrc creation logic | ||
| // This would create a .gemrc file in the user's home directory | ||
| // with the appropriate authentication configuration | ||
| return fmt.Errorf("CreateGemrc not yet implemented") | ||
| } |
Collaborator
There was a problem hiding this comment.
is this required since the scope is only to support ruby gems config?
Collaborator
Author
There was a problem hiding this comment.
not needed, have removed it, Thanks
artifactory/commands/ruby/ruby.go
Outdated
Comment on lines
92
to
100
| // RunGemCommand runs a gem command with the provided arguments | ||
| func RunGemCommand(args []string) error { | ||
| cmd := exec.Command("gem", args...) | ||
| output, err := cmd.CombinedOutput() | ||
| if err != nil { | ||
| return errorutils.CheckErrorf("gem command failed with: %q, output: %s", err, string(output)) | ||
| } | ||
| return nil | ||
| } |
Collaborator
There was a problem hiding this comment.
not valid for the current scope
Collaborator
Author
There was a problem hiding this comment.
yeah you are right, I have removed that.
agrasth
force-pushed
the
feature/ruby-gems-support-2
branch
from
4220169 to
476109c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.